https://bugs.contribs.org/show_bug.cgi?id=10655

--- Comment #16 from Terry Fage <[email protected]> ---
VERIFICATION

= Environment: 
SME 9.2 x64 VM updates as at 27 Nov 18

= ORIGINAL PROBLEM:
Bug 10655 - runmysql hard coded directory ignore backupdir key

= RESOLUTION:
Fixed in smeserver-automysqlbackup-3_0_RC6-11_el6_sme

* Mon Nov 26 2018 John Crisp <[email protected]> 3.0.RC6-11.sme
- fix runmysqlscript to allow for change in Backupdir key [SME: 10655]

= CURRENT VERSION INSTALLED:
[root@sme9264 ~]# cat /etc/e-smith-release
SME Server release 9.2

[root@sme9264 ~]# uname -r
2.6.32-754.6.3.el6.x86_64

[root@sme9264 ~]# rpm -q smeserver-automysqlbackup
smeserver-automysqlbackup-3.0.RC6-10.el6.sme.noarch

[root@sme9264 ~]# rpm -q automysqlbackup
automysqlbackup-3.0.RC6-5.el6.sme.noarch

[root@sme92x64 ~]# signal-event post-upgrade; signal-event reboot

[root@sme9264 ~]# rpm -q smeserver-mysql55
smeserver-mysql55-2.0.0-8.el6.sme.noarch

[root@sme9264 ~]# config show mysql55-mysqld
mysql55-mysqld=service
    LocalNetworkingOnly=yes
    status=enabled

[root@sme9264 ~]# config show automysqlbackup
automysqlbackup=webapp
    Backup_local_files=
    Backupdir=/root/backup/db
    DbPassword=####
    Dbencrypt_password=####
    Encrypt=no
    Hour=4
    Mailcontent=log
    Mailto=root
    Minute=1
    Mymaria=disabled
    Mysql53=enabled
    Mysql55=enabled
    Mysql57=disabled
    Sizemail=8000

= TESTING:
[root@sme9264 ~]# automysqlbackup
Invoking backup method.

Parsed config file "/etc/automysqlbackup/myserver.conf"

# Checking for permissions to write to folders:
base folder /root/backup ... exists ... ok.
backup folder /root/backup/db ... exists ... writable? yes. Proceeding.

[root@sme9264 ~]# cd backup/db
[root@sme9264 db]# ls -l
total 28
drwx------ 6 root root 4096 Nov 27 23:52 daily
drwx------ 2 root root 4096 Nov 28 04:01 fullschema
drwx------ 2 root root 4096 Nov 27 23:52 latest
drwx------ 2 root root 4096 Nov 27 23:52 monthly
drwx------ 2 root root 4096 Nov 28 04:01 status
drwx------ 2 root root 4096 Nov 27 23:52 tmp
drwx------ 2 root root 4096 Nov 27 23:52 weekly

[root@sme9264 ~]# cd /root/backup/db/daily/mysql
[root@sme9264 mysql]# ls -l
total 1440
-r-------- 1 root root 144849 Nov 28 00:55
daily_mysql_2018-11-28_00h55m_Wednesday.sql.gz
-r-------- 1 root root 144849 Nov 28 04:01
daily_mysql_2018-11-28_04h01m_Wednesday.sql.gz

[root@sme9264 ~]# config setprop automysqlbackup Backupdir /root/backupbug/db

[root@sme9264 ~]# config show automysqlbackup
automysqlbackup=webapp
    Backup_local_files=
    Backupdir=/root/backupbug/db
    DbPassword=####
    Dbencrypt_password=####
    Encrypt=no
    Hour=4
    Mailcontent=log
    Mailto=root
    Minute=1
    Mymaria=disabled
    Mysql53=enabled
    Mysql55=enabled
    Mysql57=disabled
    Sizemail=8000

[root@sme9264 ~]# mkdir -p /root/backupbug/db

[root@sme9264 mysql]# cd /root/backupbug/db

[root@sme9264 db]# automysqlbackup
Invoking backup method.

Parsed config file "/etc/automysqlbackup/myserver.conf"

# Checking for permissions to write to folders:
base folder /root/backupbug ... exists ... ok.
backup folder /root/backupbug/db ... exists ... writable? yes. Proceeding.


[root@sme9264 db]# ls -l
total 28
drwx------ 6 root root 4096 Nov 28 17:45 daily
drwx------ 2 root root 4096 Nov 28 17:45 fullschema
drwx------ 2 root root 4096 Nov 28 17:45 latest
drwx------ 2 root root 4096 Nov 28 17:45 monthly
drwx------ 2 root root 4096 Nov 28 17:45 status
drwx------ 2 root root 4096 Nov 28 17:45 tmp
drwx------ 2 root root 4096 Nov 28 17:45 weekly

[root@sme9264 mysql]# cd /root/backupbug/db/daily/mysql
[root@sme9264 mysql]# ls -l
total 288
-rw------- 1 root root 144849 Nov 28 17:45
daily_mysql_2018-11-28_17h45m_Wednesday.sql.gz
-rw------- 1 root root 144849 Nov 28 17:59
daily_mysql_2018-11-28_17h59m_Wednesday.sql.gz

[root@sme9264 mysql]# config setprop automysqlbackup Backupdir ""

[root@sme9264 mysql]# config show automysqlbackup
automysqlbackup=webapp
    Backup_local_files=
    Backupdir=
    DbPassword=####
    Dbencrypt_password=###
    Encrypt=no
    Hour=4
    Mailcontent=log
    Mailto=root
    Minute=1
    Mymaria=disabled
    Mysql53=enabled
    Mysql55=enabled
    Mysql57=disabled
    Sizemail=8000
[root@sme9264 mysql]# automysqlbackup
Invoking backup method.

Parsed config file "/etc/automysqlbackup/myserver.conf"

# Checking for permissions to write to folders:
base folder . ... exists ... ok.
backup folder  ... creating ... failed. Exiting.
Note: Supplied more than one argument, ignoring ALL arguments - using default
and global config file only.
Error: Could not create the backup_dir . Please check permissions of the higher
directory.
/usr/local/bin/automysqlbackup: line 850: 6: Bad file descriptor
/usr/local/bin/automysqlbackup: line 851: 7: Bad file descriptor
Skipping normal output methods, since the program exited before any log files
could be created.
dir

Behaviour was consistent when scenarios as per comment 2 of Bug were evaluated

= UPDATED VERSION INSTALLED:
[root@sme9264 ~]# yum update --enablerepo=smetest smeserver-automysqlbackup

[root@sme92x64 ~]# signal-event post-upgrade; signal-event reboot

[root@sme9264 ~]# rpm -q smeserver-automysqlbackup
smeserver-automysqlbackup-3.0.RC6-11.el6.sme.noarch

[root@sme9264 ~]# config show automysqlbackup
automysqlbackup=webapp
    Backup_local_files=
    Backupdir=/root/backupbug/db
   
DbPassword=pP2DvwoHw3LgTUGkIAx2c6hAcjcD8L/7O2/HH7/mUIVVPQfeiDr4X9NiXiE8GyAmky9I7QXS9wLkPPdl
    Dbencrypt_password=01234567899876543210
    Encrypt=no
    Hour=4
    Mailcontent=log
    Mailto=root
    Minute=1
    Mymaria=disabled
    Mysql53=enabled
    Mysql55=enabled
    Mysql57=disabled
    Sizemail=8000

[root@sme9264 ~]# /sbin/e-smith/runmysqlbackup
/etc/automysqlbackup/myserver.conf

[root@sme9264 ~]# automysqlbackup
Invoking backup method.

Parsed config file "/etc/automysqlbackup/myserver.conf"

# Checking for permissions to write to folders:
base folder /root/backupbug ... exists ... ok.
backup folder /root/backupbug/db ... exists ... writable? yes. Proceeding.

[root@sme9264 mysql]# ls -l
total 720
-r-------- 1 root root 144849 Nov 28 17:45
daily_mysql_2018-11-28_17h45m_Wednesday.sql.gz
-r-------- 1 root root 144849 Nov 28 17:59
daily_mysql_2018-11-28_17h59m_Wednesday.sql.gz
-r-------- 1 root root 144848 Nov 28 20:12
daily_mysql_2018-11-28_20h12m_Wednesday.sql.gz
-r-------- 1 root root 144848 Nov 28 20:13
daily_mysql_2018-11-28_20h13m_Wednesday.sql.gz
-r-------- 1 root root 144848 Nov 28 20:16
daily_mysql_2018-11-28_20h16m_Wednesday.sql.gz

[root@sme9264 mysql]# config setprop automysqlbackup Backupdir /root/backup/db
[root@sme9264 mysql]# /sbin/e-smith/runmysqlbackup
/etc/automysqlbackup/myserver.conf
[root@sme9264 mysql]# automysqlbackup
Invoking backup method.

Parsed config file "/etc/automysqlbackup/myserver.conf"

# Checking for permissions to write to folders:
base folder /root/backup ... exists ... ok.
backup folder /root/backup/db ... exists ... writable? yes. Proceeding.

[root@sme9264 mysql]# cd /root/backup/db/daily/mysql
[root@sme9264 mysql]# ls -l
total 1872
-r-------- 1 root root 144849 Nov 28 18:24
daily_mysql_2018-11-28_18h24m_Wednesday.sql.gz
-r-------- 1 root root 144848 Nov 28 20:11
daily_mysql_2018-11-28_20h11m_Wednesday.sql.gz
-r-------- 1 root root 144848 Nov 28 20:19
daily_mysql_2018-11-28_20h19m_Wednesday.sql.gz

Overcopme issue of a blank backup dir in config

[root@sme9264x ~]# rpm -q automysqlbackup
automysqlbackup-3.0.RC6-5.el6.sme.noarch

[root@sme9264 ~]# yum update --enablerepo=smetest automysqlbackup

[root@sme92x64 ~]# signal-event post-upgrade; signal-event reboot

[root@sme9264x ~]# rpm -q automysqlbackup
automysqlbackup-3.0.RC6-6.el6.sme.noarch

No errors evident

= PROBLEM FIXED:
runmysql has hardcoded chown and chmod which will ignore a change in the
backupdir key

= VERIFIED OR REOPEN:
Verified

= DOCUMENTATION IMPACT:
N/A

= SUGGESTED RELEASE NOTES:
%Changelog
* Mon Nov 26 2018 John Crisp <[email protected]> 3.0.RC6-11.sme
- fix runmysqlscript to allow for change in Backupdir key [SME: 10655]

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
_______________________________________________
Mail for each SME Contribs bug report
To unsubscribe, e-mail [email protected]
Searchable archive at https://lists.contribs.org/mailman/public/contribteam/

Reply via email to