Thanks. -----Original Message----- From: Robert Varga [mailto:n...@hq.sk] Sent: Friday, October 14, 2016 12:15 PM To: Sela, Guy <guy.s...@hpe.com>; controller-dev@lists.opendaylight.org; d...@lists.opendaylight.org Subject: Re: [opendaylight-dev] Lombok
On 10/13/2016 10:13 PM, Sela, Guy wrote: > Hi, > > > > Did anyone consider adding Lombok into ODL? > > > > https://projectlombok.org/features/ > > https://gualtierotesta.wordpress.com/2014/03/03/tutorial-using-lombok- > to-reduce-boilerplate-code-in-java/ Not seriously, no. There are three main reasons: 1) for inter-component interactions we use YANG and hence have an equivalent for getters/builders/hashCode/equals 2) concerns about code readability and learning curve for newcomers 3) it makes performance trade-offs without giving sufficient control. For example https://projectlombok.org/features/GetterLazy.html -- that AtomicReference is used only as a lock, wasting 16-24 bytes of memory for each such field. Overall it does not look like a mature enough project for the code we have evaluated it for (yangtools, mdsal, bgpcep). Regards, Robert _______________________________________________ controller-dev mailing list controller-dev@lists.opendaylight.org https://lists.opendaylight.org/mailman/listinfo/controller-dev
