Tom, thanks for jumping in! +controller-dev & genius-dev, to make this formerly private thread public (and -individuals, because of mailman); because this may be a more general issue, not just something done wrong in c/49175:
On Thu, Jan 19, 2017 at 12:29 PM, Tom Pantelis <tpant...@brocade.com> wrote: Let's use https://bugs.opendaylight.org/show_bug.cgi?id=7595 to track this story... as I've seen what to me now looks like the same problem in a number of places. One first random thought: this couldn't simply be down to that whatever feature brings DOMRpcService (type=default)(!(type=*) is missing in a number of feature.xml, is it? Like what feature actually has the bundle that registers the implementation of DOMRpcService ? I looked and find (at least) 7 implementations of interface DOMRpcService in the code - which one of these is the "real" production one we expect should have been found, but was not? Where does that implementation of DOMRpcService get registered into the global OSGi service registry? Knowing then, we could back trace from that.. Maybe I'll hack a quick Service Tracker that logs when OSGi services get (de)registered during SFT - I think it would help understand this, and future problems like it, more easily. The rpc-service extension (RpcServiceMetadata) uses the DOMRpcService to > find and wait for the desired RpcService to be registered. It uses a > DOMRpcAvailabilityListener which had some recent changes. > I'm not 100% sure if the error message is telling us that something (org.opendaylight.controller.blueprint.ext.RpcServiceMetadata) could not find a DOMRpcService, or that the DOMRpcService was found and then could not find the desired particular RpcService, but from what I understand so far it's the former, do you agree? So not about the DOMRpcAvailabilityListener about about RpcServiceMetadata? BTW; Where is dependency to DOMRpcService declared? There is no BP for that, but it's initiated "programmatically" in line 99 of RpcServiceMetadata, am I getting this right? Tom are you on IRC tomorrow to dig into this together with Robert and me? (I'm on-and-off in the coming hours today.) > ________________________________________ > From: Robert Varga <n...@hq.sk> > Sent: Thursday, January 19, 2017 6:19 AM > To: Michael Vorburger; Faseela K; Kitt, Stephen; Sam Hague; Tom Pantelis > Cc: N Edwin Anthony; David Suarez Fuentes > Subject: Re: Interfacemanager blueprint migration, dependency issues, need > help > > It does look like a problem in BP wiring *somewhere*. > > The OFP feature failing for me is not actually using DOMRpcService, but > has an odl:rpc-service reference. > > Now my patch mucks around there (it plugs into DOMRpcService), but I do > not see how it can interfere with it. > > Tom, any ideas on how to debug this? > > Thanks, > Robert > > On 01/19/2017 12:10 PM, Michael Vorburger wrote: > > +Robert & +Tom - perhaps either of can you help us shed some light on > this? > > > > Robert, it looks like the same problem you're hitting on > > https://jenkins.opendaylight.org/releng/job/controller-distr > ibution-check-carbon/1441/consoleFull#305750893e5f83968-6a6e > -4afa-aebf-7456048eb3ce > > (for https://git.opendaylight.org/gerrit/#/c/50488/) is similar to this > > again. > > > > Some tips to locally reproduce this for investigation without having to > > wait too long for SFT: > > > > 1. comment out the other features (for > > https://git.opendaylight.org/gerrit/#/c/49175/ e.g. in > > genius/features/src/main/features/features.xml ('odl-genius-api', > > 'odl-genius-fcaps-framework', 'odl-genius-fcaps-application') > > > > 2. reduce the .atMost(5, MINUTES) in TestBundleDiag in odlparent > > > > Not sure if relevant: when I did an 'install' in interfacemanager-impl > > and then 'package' the genius/features, and get a similar failure with > > the c/49175 Gerrit it has 3/6 features failing on Jenkins, whereas for > > me locally, curiously, it's 2/6, the main feature ('odl-genius') sails > > through, only 'odl-genius-rest' & 'odl-genius-ui' falls flat (due to > > DOMRpcService). > > > > > On Wed, Jan 18, 2017 at 6:32 PM, Michael Vorburger <vorbur...@redhat.com > > <mailto:vorbur...@redhat.com>> wrote: > > > > On Wed, Jan 18, 2017 at 9:12 AM, Faseela K <faseel...@ericsson.com > > <mailto:faseel...@ericsson.com>> wrote: > > > > Michael/Sam,____ > > > > Edwin has rebased his patch, good that now Michael’s test > > framework is catching the error during build time itself.____ > > > > However we are not able to identify what is the reason for the > > failure. > > > > > > I've just locally pulled and repro. it, and unfortunately have to > > admit I'm also not getting what the problem is on this one... Sam or > > Stephen probably will have to take a closer look. I'm interested in > > learning myself how these MDSAL RPC relate to Blueprint OSGi > > services - I don't fully get what's happening there, and would love > > to be able to fully understand this, to be able to debug this kind > > of problem. > > > > BTW: I think I actually seen a very similar looking problem > > elsewhere recently; the new extended SingleFeatureTest incl. > > TestBundleDiag shows lots of errors like this in > > integration/distribution/features-test/target/surefire-repo > rts/org.opendaylight.odlparent.featuretest.SingleFeatureTest-output.txt > > for "odl-integration-all" feature ... (and similarly > > unimgr/features "odl-unimgr-netvirt and lispflowmapping/features > > "odl-lispflowmapping-mappingservice", > > "odl-lispflowmapping-mappingservice-shell", > > "odl-lispflowmapping-neutron", "odl-lispflowmapping-ui" - I think). > > > > > > ____ > > > > Funny thing is the test is showing NOK for alivenessmonitor > > and arputil as well, which is already merged, and working > > without issues.____ > > > > __ __ > > > > https://jenkins.opendaylight.org/releng/job/genius-verify-c > arbon-mvn33-openjdk8/1120/consoleFull#1038007923e5f83968-6a6 > e-4afa-aebf-7456048eb3ce > > <https://jenkins.opendaylight.org/releng/job/genius-verify- > carbon-mvn33-openjdk8/1120/consoleFull#1038007923e5f83968- > 6a6e-4afa-aebf-7456048eb3ce>____ > > > > __ __ > > > > Thanks,____ > > > > Faseela____ > > > > __ __ > > > > *From:*N Edwin Anthony > > *Sent:* Wednesday, January 18, 2017 1:37 PM > > *To:* Sam Hague <sha...@redhat.com <mailto:sha...@redhat.com>> > > *Cc:* Michael Vorburger <vorbur...@redhat.com > > <mailto:vorbur...@redhat.com>>; Faseela K > > <faseel...@ericsson.com <mailto:faseel...@ericsson.com>>; David > > Suarez Fuentes <david.suarez.fuen...@ericsson.com > > <mailto:david.suarez.fuen...@ericsson.com>> > > *Subject:* RE: Interfacemanager blueprint migration, dependency > > issues, need help____ > > > > __ __ > > > > Hi Sam, ____ > > > > > > Yes all the RPCs have be exposed as is, I double checked with > > Faseela. > > Does it require me to make changes to the way I’m > > declaring/calling RPCs ? > > > > > > Thank you,____ > > > > Edwin.____ > > > > __ __ > > > > PS: review link https://git.opendaylight.org/gerrit/#/c/49175/ > > <https://git.opendaylight.org/gerrit/#/c/49175/>____ > > > > __ __ > > > > *From:*Sam Hague [mailto:sha...@redhat.com] > > *Sent:* Saturday, January 14, 2017 4:39 PM > > *To:* N Edwin Anthony > > *Cc:* Michael Vorburger; Faseela K; David Suarez Fuentes > > *Subject:* RE: Interfacemanager blueprint migration, dependency > > issues, need help____ > > > > __ __ > > > > Edwin, ____ > > > > __ __ > > > > That one is a little confusing because it makes you look for > > that directly, but it's really an rpc exposed by Genius that > > uses the DomRpc. Doublecheck that all the rpc's are still > > exposed from before and after the patch. Look at latest code to > > see if one was added since you started your patch.____ > > > > __ __ > > > > Sam____ > > > > __ __ > > > > __ __ > > > > On Jan 14, 2017 3:01 AM, "N Edwin Anthony" > > <n.edwin.anth...@ericsson.com > > <mailto:n.edwin.anth...@ericsson.com>> wrote:____ > > > > Hi Sam, > > > > When I run bundle:diag on karaf console I am getting the > > following message:____ > > > > ____ > > > > cid:image001.png@01D2718F.EE21F2F0 > > > > In the patch I uploaded no direct reference was made to > > DOMRpcService, which is why I am unsure where it is coming > from.____ > > > > ____ > > > > Thank you,____ > > > > Edwin.____ > > > > ____ > > > > *From:*Sam Hague [mailto:sha...@redhat.com > > <mailto:sha...@redhat.com>] > > *Sent:* Friday, January 13, 2017 5:49 PM > > *To:* N Edwin Anthony > > *Cc:* Faseela K; Michael Vorburger; David Suarez Fuentes > > *Subject:* Re: Interfacemanager blueprint migration, dependency > > issues, need help____ > > > > ____ > > > > What pops up when you run the bundle dial? That usually shows > > the missing wiring. ____ > > > > ____ > > > > The log below is showing an issue related to interfacemanager. > > Vpnmanager blocked on fibmanager and elanservice with > > interfacemanager and mdsalutils, so maybe the interaction is > > there. ____ > > > > ____ > > > > On Jan 13, 2017 1:39 AM, "N Edwin Anthony" > > <n.edwin.anth...@ericsson.com > > <mailto:n.edwin.anth...@ericsson.com>> wrote:____ > > > > Hi All, > > > > I was earlier working on InterfaceManager Blueprint migration, > > my final changes were pushed. > > Back then it was working perfectly fine locally, yet again I had > > to wait because of CSIT/Jenkin issues. > > > > As of now when I bring up the bundle, I am facing issues with > > dependencies which were not declared in my changes: > > > > 2017-01-13 11:41:32,567 | INFO | l for user > > karaf | BlueprintContainerImpl | 15 - > > org.apache.aries.blueprint.core - 1.6.1 | Bundle > > org.opendaylight.netvirt.vpnmanager-impl/0.4.0.SNAPSHOT is > > waiting for dependencies > > [(&(|(type=default)(!(type=*)))(objectClass=org.opendayligh > t.controller.md > > <http://opendaylight.controller.md>.sal.dom.api.DOMRpcService)), > > (objectClass=org.opendaylight.genius.interfacemanager.inter > faces.IInterfaceManager), > > (objectClass=org.opendaylight.netvirt.fibmanager.api.IFibMa > nager), > > (&(|(type=default)(!(type=*)))(objectClass=org.opendaylight > .controller.md.sal.dom.api.DOMRpcService)), > > (objectClass=org.opendaylight.netvirt.elanmanager.api.IElan > Service), > > (&(|(type=default)(!(type=*)))(objectClass=org.opendaylight > .controller.md.sal.dom.api.DOMRpcService)), > > (&(|(type=default)(!(type=*)))(objectClass=org.opendaylight > .controller.md.sal.dom.api.DOMRpcService)), > > (&(|(type=default)(!(type=*)))(objectClass=org.opendaylight > .controller.md.sal.dom.api.DOMRpcService)), > > (objectClass=org.opendaylight.genius.mdsalutil.interfaces.IM > > <http://genius.mdsalutil.interfaces.IM>dsalApiManager)] > > 2017-01-13 11:41:32,583 | INFO | rint Extender: 3 | > > BlueprintContainerImpl | 15 - > > org.apache.aries.blueprint.core - 1.6.1 | Bundle > > org.opendaylight.netvirt.vpnmanager-impl/0.4.0.SNAPSHOT is > > waiting for dependencies > > [(&(|(type=default)(!(type=*)))(objectClass=org.opendayligh > t.controller.md > > <http://opendaylight.controller.md>.sal.dom.api.DOMRpcService)), > > (objectClass=org.opendaylight.genius.interfacemanager.inter > faces.IInterfaceManager), > > (objectClass=org.opendaylight.netvirt.fibmanager.api.IFibMa > nager), > > (&(|(type=default)(!(type=*)))(objectClass=org.opendaylight > .controller.md.sal.dom.api.DOMRpcService)), > > (objectClass=org.opendaylight.netvirt.elanmanager.api.IElan > Service), > > (&(|(type=default)(!(type=*)))(objectClass=org.opendaylight > .controller.md.sal.dom.api.DOMRpcService)), > > (&(|(type=default)(!(type=*)))(objectClass=org.opendaylight > .controller.md.sal.dom.api.DOMRpcService)), > > (objectClass=org.opendaylight.genius.mdsalutil.interfaces.IM > > <http://genius.mdsalutil.interfaces.IM>dsalApiManager)] > > 2017-01-13 11:41:32,583 | INFO | rint Extender: 3 | > > BlueprintContainerImpl | 15 - > > org.apache.aries.blueprint.core - 1.6.1 | Bundle > > org.opendaylight.netvirt.vpnmanager-impl/0.4.0.SNAPSHOT is > > waiting for dependencies > > [(&(|(type=default)(!(type=*)))(objectClass=org.opendayligh > t.controller.md > > <http://opendaylight.controller.md>.sal.dom.api.DOMRpcService)), > > (objectClass=org.opendaylight.genius.interfacemanager.inter > faces.IInterfaceManager), > > (objectClass=org.opendaylight.netvirt.fibmanager.api.IFibMa > nager), > > (&(|(type=default)(!(type=*)))(objectClass=org.opendaylight > .controller.md.sal.dom.api.DOMRpcService)), > > (objectClass=org.opendaylight.netvirt.elanmanager.api.IElan > Service), > > (&(|(type=default)(!(type=*)))(objectClass=org.opendaylight > .controller.md.sal.dom.api.DOMRpcService)), > > (&(|(type=default)(!(type=*)))(objectClass=org.opendaylight > .controller.md.sal.dom.api.DOMRpcService)), > > (objectClass=org.opendaylight.genius.mdsalutil.interfaces.IM > > <http://genius.mdsalutil.interfaces.IM>dsalApiManager)] > > > > May I know where am I going wrong, and how to fix it ? > > Thank you, > > Edwin. > > > > PS: review link, https://git.opendaylight.org/gerrit/49175 > > <https://git.opendaylight.org/gerrit/49175> > >
_______________________________________________ controller-dev mailing list controller-dev@lists.opendaylight.org https://lists.opendaylight.org/mailman/listinfo/controller-dev
