Hello, On Mon, Feb 6, 2017 at 2:00 PM, Michael Vorburger <vorbur...@redhat.com> wrote:
> +controller-dev & +genius-dev FYI > > On Mon, Feb 6, 2017 at 9:39 AM, Kochba, Alon <alo...@hpe.com> wrote: > >> Thanks Suneelu, merged. >> >> Michael, please have a look later (are other projects affected?). >> > > Oups... so https://git.opendaylight.org/gerrit/#/c/51307/ affected some > tests (not broke compilation) - sorry! > > FYI even genius' MdSalUtilTest, which broke similarly to test(s) in > netvirt (which?) due to this change in controller. > I just wanted to follow-up to wrap this up, in case anyone was interested in how this https://bugs.opendaylight.org/show_bug.cgi?id=7538 story ended up: https://git.opendaylight.org/gerrit/#/c/51486/ is meanwhile in controller, and added a new AbstractConcurrentDataBrokerTest which @deprecate-s the AbstractDataBrokerTest. Any existing tests which originally broke with this change (i.e. the original story below) actually turned out to be badly written strictly speaking already broken tests; please see e.g. https://git.opendaylight.org/gerrit/#/c/51487/ and https://git.opendaylight.org/gerrit/#/c/51490/ for examples how to fix such tests. Tx, M. -- Michael Vorburger <vorbur...@redhat.com> | IRC: vorburger @freenode | ~ = http://vorburger.ch > > I've just raised https://git.opendaylight.org/gerrit/#/c/51467/ to revert > c/51307. (Sunnela, perhaps you'd like to revert > https://git.opendaylight.org/gerrit/#/c/51451/ again once > https://git.opendaylight.org/gerrit/#/c/51467/ is merged?) > > I'll propose a new change to controller to make this (multi threading > support in DataBroker test) an option instead, to keep 100% backward > compatibility, yet allow tests, such as the ElanServiceTest component test > that are affected by the problem, to solve it. FYI > https://bugs.opendaylight.org/show_bug.cgi?id=7538 has full background > story of what this is all about. > > > >> >> >> --alon >> >> >> >> *From:* netvirt-dev-boun...@lists.opendaylight.org [mailto: >> netvirt-dev-boun...@lists.opendaylight.org] *On Behalf Of *K.V Suneelu >> Verma >> *Sent:* Monday, 6 February 2017 09:20 >> *To:* Michael Vorburger <vorbur...@redhat.com> >> *Cc:* netvirt-...@lists.opendaylight.org >> *Subject:* Re: [netvirt-dev] netvirt builds broken >> >> >> >> Hi, >> >> >> >> I Raised the following patch for netvirt. >> >> https://git.opendaylight.org/gerrit/#/c/51451/ >> >> >> >> Thanks, >> >> Suneelu >> >> >> >> *From:* K.V Suneelu Verma >> *Sent:* Monday, February 06, 2017 12:07 PM >> *To:* Michael Vorburger >> *Cc:* netvirt-...@lists.opendaylight.org >> *Subject:* netvirt builds broken >> >> >> >> Hi Michael, >> >> The following commit in controller has broken netvirt builds. >> >> https://git.opendaylight.org/gerrit/#/c/51307/ >> >> >> >> I am not sure if the same commit is responsible for ovsdb build >> breakage also. >> >> >> >> Thanks, >> >> Suneelu >> > >
_______________________________________________ controller-dev mailing list controller-dev@lists.opendaylight.org https://lists.opendaylight.org/mailman/listinfo/controller-dev
