Great! Thanks a lot! . FaaS is already migrated into karaf 4. So that shouldn't be a problem...
Thanks Xingjun -----Original Message----- From: Robert Varga [mailto:n...@hq.sk] Sent: Friday, June 30, 2017 2:11 PM To: Xingjun Chu <xingjun....@huawei.com>; controller-dev@lists.opendaylight.org <controller-dev@lists.opendaylight.org> Cc: faas-...@lists.opendaylight.org <faas-...@lists.opendaylight.org> Subject: Re: https://git.opendaylight.org/gerrit/#/c/50190/7 Yes, just change odlparent artifact versions to 2.0.0 (without snapshot) and fix up the failures. Essentially you need to switch to Karaf 4 and fix up compile failures... Original Message From: xingjun....@huawei.com Sent: June 30, 2017 19:53 To: n...@hq.sk; controller-dev@lists.opendaylight.org Cc: faas-...@lists.opendaylight.org Subject: RE: https://git.opendaylight.org/gerrit/#/c/50190/7 Hi Robert, I checked, We are still on odlparent-lite 1.8.0-SNAPSHOT. GBP has dependency on FaaS and that prevent GBP moving on to odlparent-2.0.0. I try to migrate FaaS to odlparent 2.0.0. Do you know how to make the move Or just simply change the artifactid and version. ? it may be more work than that? In that case, we can just forget your patch? Thanks a lot Xingjun -----Original Message----- From: Robert Varga [mailto:n...@hq.sk] Sent: Friday, June 30, 2017 12:11 PM To: Xingjun Chu <xingjun....@huawei.com>; controller-dev@lists.opendaylight.org <controller-dev@lists.opendaylight.org> Cc: faas-...@lists.opendaylight.org <faas-...@lists.opendaylight.org> Subject: Re: https://git.opendaylight.org/gerrit/#/c/50190/7 Hello Xingjun, That is a Guava migration patch. It adapts faas to guava-21, but I have not updated it in along time. If faas is on odlparent-2.0.0, I will abandon it. If not, you may find it useful during that migration. Essentially Guava 's Futures.transform() is noonger overloaded... Regards, Robert Original Message From: xingjun....@huawei.com Sent: June 30, 2017 18:05 To: n...@hq.sk; controller-dev@lists.opendaylight.org Cc: faas-...@lists.opendaylight.org Subject: https://git.opendaylight.org/gerrit/#/c/50190/7 Hi Robert, You submitted a patch for FaaS, it compiled failed with repeated following error, the symbol transformAsync is not found. Is this a new function introduced? Why we need to move to it? [ERROR] location: class com.google.common.util.concurrent.Futures [ERROR] /w/workspace/faas-verify-nitrogen-mvn33-openjdk8/fabrics/fabric/src/main/java/org/opendaylight/faas/fabric/general/EndPointRegister.java:[173,23] cannot find symbol [ERROR] symbol: method transformAsync(com.google.common.util.concurrent.CheckedFuture<java.lang.Void,org.opendaylight.controller.md.sal.common.api.data.TransactionCommitFailedException>,<anonymous com.google.common.util.concurrent.AsyncFunction<java.lang.Void,org.opendaylight.yangtools.yang.common.RpcResult<java.lang.Void>>>,java.util.concurrent.ExecutorService) [ERROR] location: class com.google.common.util.concurrent.Futures Thanks Xingjun _______________________________________________ controller-dev mailing list controller-dev@lists.opendaylight.org https://lists.opendaylight.org/mailman/listinfo/controller-dev
