On Fri, Jul 28, 2017 at 12:35 AM, Ryan Goulding <ryandgould...@gmail.com> wrote:
Sometimes people spawn test appenders to do log collection in unit tests. > I have done this in AAA when i was expecting very specific accounting > messages. I believe that is the point of some of this... > Do you know we have the LogCaptureRule as announced on https://lists.opendaylight.org/pipermail/dev/2017-July/003928.html in infrautils for this now? It allows you to do log collection in unit tests. If you have a need for it to do more than it currently does, help extend it? Are you aware of, or can you help find, any remaining usages of TestAppender? I think its better to not use a chainsaw... > Robert said to remove logback from controller, so I am! ;) > Regards, > > Ryan Goulding > > On Thu, Jul 27, 2017 at 3:01 PM, Michael Vorburger <vorbur...@redhat.com> > wrote: > >> On Thu, Jul 27, 2017 at 11:51 PM, Robert Varga <n...@hq.sk> wrote: >> >>> On 27/07/17 13:05, Michael Vorburger wrote: >>> > Hello parents, >>> >>> Hello Michael, >>> >>> > as I'm having a closer look at what we've done re. logging, I'm >>> > discovering that in an ODL $KARAF_HOME we have: >>> > >>> > 1. a etc/org.ops4j.pax.logging.cfg (from >>> > odlparent/karaf/opendaylight-karaf-resources/src/main/resour >>> ces/etc/org.ops4j.pax.logging.cfg) >>> > >>> > VS >>> > >>> > 2. configuration/logback.xml (from >>> > odlparent/karaf/opendaylight-karaf-resources/src/main/resour >>> ces/configuration/logback.xml) >>> > >>> > >>> > I thought we (Karaf) used Log4j v2 (through the slf4j API, with OPS4j's >>> > PAX Logging in the middle playing some role) - so that is that LogBack >>> > configuration used for?? >>> >>> The logback piece should be removed from controller, as it did not work >>> since we moved to karaf, as far as I can tell... >>> >> >> I'm probably missing some history here, and didn't immediately get why >> you mentioned "from controller" here when I (just) asked about the >> odlparent karaf, but with a grep am seeing that there is (a lot) of logback >> related stuff in controller... >> >> >>> Michael, can you spare some time to cook up a patch? >>> >> >> sure, but full disclosure: I've no idea what I'm doing here, I just went >> in with a chainsaw, and: >> >> https://git.opendaylight.org/gerrit/#/c/60833/ >> >> https://git.opendaylight.org/gerrit/#/c/60830/ >> >> >>> Thanks, >>> Robert >>> >>> >> >> _______________________________________________ >> controller-dev mailing list >> controller-dev@lists.opendaylight.org >> https://lists.opendaylight.org/mailman/listinfo/controller-dev >> >> >
_______________________________________________ controller-dev mailing list controller-dev@lists.opendaylight.org https://lists.opendaylight.org/mailman/listinfo/controller-dev
