On Wed, 2 Jul 2003 13:09:41 +0200
Per �yvind Karlsen <[EMAIL PROTECTED]> wrote:


> should be fixed in wine-20030618-4mdk, related to stupid use of 
> $RPM_BUILD_ROOT in makefiles..

that stupid use is there because we patched it in there and we had all
reason to do so. However,

> such variables should never been used in makefiles IMHO..

yea right, that's why I proposed this to cooker on, let's see, April 30

-----
due to popular demand for a fix of manpages and apploader script:

s/RPM_BUILD_ROOT/DESTDIR/    destdir.patch

fixes buildroot being present in manpage files section and apploader
scripts (ie notepad etc). Should make build more sane in general. No
adverse side effects here.

Explanation: while RPM_BUILD_ROOT is set from start, DESTDIR is set at
makeinstall_std, ie after make. At make stage it is empty and doesn't
get in the way when building.

new patch attached
-----

both the explanation and the new patch were sent again on May 7

So I'll try again to propose this one. The attached patch REPLACES
patch1. There's no diff to patch1 because the diff is trivial: If you
like you can unpack patch1 and then

sed -e "s/RPM_BUILD_ROOT/DESTDIR/" wine-20021219-destdir.patch >
wine-20030702-destdir.patch

and update the spec

Mark

Attachment: wine-20030430-destdir.patch.bz2
Description: Binary data

Reply via email to