On Tuesday 22 July 2003 09:51, Ben Reser wrote:
> Done and attached.  The README file that is attached should go in
> /etc/sysconfig/dnotify.d for documentation purposes...

One more problem: If you do have an /etc/sysconfig/dnotify, but it consists of 
nothing but comments, then "service dnotify start" will do nothing (and 
report "FAILED"), but it will touch the lockfile anyway. So "service dnotify 
status" will report "dnotify dead but subsys locked", and "service dnotify 
stop" will fail.

Maybe you should do an extra grep along with the -r tests to exit early if the 
config files are empty:

--- dnotify.init.old
+++ dnotify.init
@@ -21,2 +21,5 @@

+egrep -shv '^([[:space:]]*#|[[:space:]]*$)' /etc/sysconfig/dnotify \
+    /etc/sysconfig/dnotify.d/* > /dev/null || exit 0
+
 RETVAL=0


Otherwise, it all seems to work for me. And this is definitely useful. You 
should send it to the upstream author to see if he's interested in it. And we 
should either add it to the dnotify package in contribs, or package it up on 
its own.


Reply via email to