http://qa.mandrakesoft.com/show_bug.cgi?id=4629
Product: msec
Component: msec
Summary: can't handle True and False from /etc/sysctl.conf
Product: msec
Version: 0.38-5mdk
Platform: PC
OS/Version: All
Status: UNCONFIRMED
Severity: normal
Priority: P2
Component: msec
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
In libmsec.py, set_zero_one_variable() can't handle "True" or "False" values
from /etc/sysctl.conf
See the attached patch for a possible solution.
For example, with this line in /etc/sysctl.conf :
net.ipv4.icmp_ignore_bogus_error_responses=False
msec dies with a ValueError exception :
Traceback (most recent call last):
File "/usr/share/msec/msec.py", line 266, in ?
commit_changes()
File "/usr/share/msec/mseclib.py", line 24, in commit_changes
apply(f[0], f[1])
File "/usr/share/msec/libmsec.py", line 899, in accept_bogus_error_responses
set_zero_one_variable(SYSCTLCONF,
'net.ipv4.icmp_ignore_bogus_error_responses', not arg, 1, 'Ignoring bogus icmp
error responses', 'Accepting bogus icmp error responses')
File "/usr/share/msec/libmsec.py", line 820, in set_zero_one_variable
val=int(val)
ValueError: invalid literal for int(): False
--
Configure bugmail: http://qa.mandrakesoft.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
