Guillaume Rousse wrote: > Ainsi parlait David Walser : >> Guillaume Rousse wrote: >> > [Contrib-RPM] >> > Name : imp3 Relocations: (not >> > relocateable) Version : 3.2.2 Vendor: >> > MandrakeSoft Release : 1mdk Build Date: Mon >> > 08 Sep 2003 10:46:41 PM CEST -=-=-=- >> > - drop ugly configuration scripts, perl rulez >> >> Well that's fine, but part of the point before was, the script was included >> with the package, so if the user changed their hostname later on, they >> could run the script again and have their config be right again. Do the >> same with your perl script. > All the script was doing was to replace "localhost.localdomain" by the correct > values in a config file, using two scripts, a shell one and a awk one. It > tooks me almost 10 minutes to understand it, whereas a single one-liner in > perl could do in one single place. Moreover, i don't see the point of adding > aditional code, meaning potential security and maintainance issues, > for such a trivial task, especially for what is supposed to be a server. > Either you write a complete configuration wizard, and install it elsewhere in > the filesystem, either you just takes cares of it in post-install > configuration step.
Security and Maintainance issues? That's absolutely ridiculous. Yes your line of code takes care of it in the post-install configuration step, but let me re-iterate, what if the user changes their hostname *after the package is installed.* They will need to run that line of code again. Install it as a script like was done before.
