Hi,

Recently quota support for samba has been enabled, this caused the samba
compilation to cease on my alpha:

Compiling smbd/quotas.c
smbd/quotas.c:55: parse error before `quotactl'
smbd/quotas.c:55: warning: data definition has no type or storage class
make: *** [smbd/quotas.o] Error 1
Bad exit status from /users/cooker/tmp/rpm-tmp.54760 (%build)

I remember having this problem with quota support on samba for some time
(back to the 2.0.0 days). However, RedHat is able to produce a package
for the alpha with quota support enabled. Taking a look at the
differences between the patches that RedHat and Mandrake use I found the
following:

diff samba-glibc21.patch.rh samba-glibc21.patch.mdk
1,14c1,3
< --- samba-2.0.6/source/smbd/quotas.c.glibc21  Wed Oct 13 01:26:59 1999
< +++ samba-2.0.6/source/smbd/quotas.c  Fri Feb  4 19:58:59 2000
< @@ -39,8 +39,6 @@
<  #include <mntent.h>
<  #include <linux/unistd.h>
<
< -_syscall4(int, quotactl, int, cmd, const char *, special, int, id,
caddr_t, addr);
< -
< 
/****************************************************************************< 
try to get the disk space from disk quotas (LINUX version)
< 
****************************************************************************/<
--- samba-2.0.6/source/include/includes.h.glibc21     Wed Nov 10
21:36:00 1999< +++ samba-2.0.6/source/include/includes.h     Fri Feb  4
19:58:41 2000
< @@ -652,11 +652,6 @@
---
> --- samba-2.0.7/source/include/includes.h.glibc21     Tue Jul 20 21:25:05 1999> +++ 
>samba-2.0.7/source/include/includes.h     Wed Jul 21 10:42:47 1999
> @@ -647,11 +647,6 @@
26,28c15,17
< --- samba-2.0.6/source/client/smbmount.c.glibc21      Wed Nov 10
21:35:59 1999< +++ samba-2.0.6/source/client/smbmount.c      Fri Feb  4
19:58:41 2000
< @@ -98,8 +98,11 @@
---
> --- samba-2.0.7/source/client/smbmount.c.glibc21      Tue Jul 20 21:25:02 1999> +++ 
>samba-2.0.7/source/client/smbmount.c      Wed Jul 21 10:49:28 1999
> @@ -96,8 +96,11 @@

They remove the line with the _syscall4(...
This is linenumber 55 of quotas.c, the same part the compilation
crashes. I've added the patch (removal of the _syscall4( line to
mandrake's samba-glibc21.patch, and samba compiled again (x86 also
compiles, I checked).

Can this patch be included in the cooker distro?

http://d10179.dtk.chello.nl/build/fixes/cooker/samba-2.0.7-17mdk.src.rpm
http://d10179.dtk.chello.nl/build/fixes/cooker/samba.spec
http://d10179.dtk.chello.nl/build/fixes/cooker/samba.spec.diff
http://d10179.dtk.chello.nl/build/fixes/cooker/samba.spec.orig

Stefan

Reply via email to