Hi Laurent,
>Le Dimanche 05 Ao�t 2001 18:29, Stefan van der Eijk a �crit :
>
>>Ian,
>>
>>KDE BuildRequires are not correct at the moment.
>>
>
>Hi,
>
>
>> I've fixed several packages, in one case the changes were turned back
>>in the release following mine... For some reason the KDE maintainers
>>don't accept the true BuildRequires for their packages (!?!?).
>>
>
>Kde package are very important. We (Mandrake kde team) work a lot on kde
>package and me I don't want that you break kde package.
>
I understand this.
>There is a lot of build requires, and it works. So don't touch at kde package.
>
I guess we're heading at a sensitive area...
First of all, let me get one thing clear, when I change the BuildRequires,
1/ I test to see what BuildRequires are REALLY needed to compile the
package ;
2/ I don't remove any BuildRequires "just like that" (there is science
behind it, see 3/);
3/ The BuildRequires I do remove are redundant (run the BR.sh script
against a src.rpm to find out).
Let me ellaborate:
The machine I use to compile is failry empty (in contrast with the
cluster, which has many -devel packages installed). When something
refuses to compile, I see the errors (see:
http://d10149.upc-d.chello.nl/build/cooker/i586/problem/ as evidence, at
the moment +/- 380 packages aren't compiling due to non-existant
BuildRequires, which the package DOES need to compile) and add the
required BuildRequires to the package. When the package finally
compiles, I check the urpmi log (see:
http://d10149.upc-d.chello.nl/build/cooker/urpmi/i586/ ) and remove all
the packages that are redundant. With redundant I mean, packages that
are required by other packages in the BuildRequires --> there's no need
to include them in the BuildRequires, it only makes the list longer (and
in my opinion more difficult to maintain).
What I'm trying to do is _fix_ the BuildRequires, and not break them. If
you don't beleive me, take a look at:
http://d10149.upc-d.chello.nl/build/cooker/i586/problem/qt2-2.3.1-8mdk.src.rpm.txt
g++ -c -I/users/cooker/RPM/BUILD/qt-2.3.1/include -pipe -O3 -mcpu=pentiumpro
-march=i586 -DUIC -DHAVE_KDE -I../shared -I../util -I../../../src/3rdparty/zlib
-I/usr/include -o ../integration/kdevelop/kdewidgets.o
../integration/kdevelop/kdewidgets.cpp
../integration/kdevelop/kdewidgets.cpp:24:25: kcharselect.h: No such file or directory
../integration/kdevelop/kdewidgets.cpp:25:26: kcolorbutton.h: No such file or directory
../integration/kdevelop/kdewidgets.cpp:26:23: kcombobox.h: No such file or directory
../integration/kdevelop/kdewidgets.cpp:27:22: kdatepik.h: No such file or directory
../integration/kdevelop/kdewidgets.cpp:28:22: kdatetbl.h: No such file or directory
../integration/kdevelop/kdewidgets.cpp:29:27: kdualcolorbtn.h: No such file or
directory
../integration/kdevelop/kdewidgets.cpp:30:23: kiconview.h: No such file or directory
../integration/kdevelop/kdewidgets.cpp:31:18: kled.h: No such file or directory
../integration/kdevelop/kdewidgets.cpp:32:23: klineedit.h: No such file or directory
../integration/kdevelop/kdewidgets.cpp:33:22: klistbox.h: No such file or directory
../integration/kdevelop/kdewidgets.cpp:34:23: klistview.h: No such file or directory
../integration/kdevelop/kdewidgets.cpp:35:23: knuminput.h: No such file or directory
../integration/kdevelop/kdewidgets.cpp:36:26: ktextbrowser.h: No such file or directory
../integration/kdevelop/kdewidgets.cpp:37:28: ktoolbarbutton.h: No such file or
directory
../integration/kdevelop/kdewidgets.cpp:38:23: kurllabel.h: No such file or directory
../integration/kdevelop/kdewidgets.cpp: In function `QWidget
*qt_create_kde_widget (const QString &, QWidget *, const char *,
bool)':
../integration/kdevelop/kdewidgets.cpp:226: parse error before `('
../integration/kdevelop/kdewidgets.cpp:228: parse error before `('
../integration/kdevelop/kdewidgets.cpp:230: parse error before `('
../integration/kdevelop/kdewidgets.cpp:232: parse error before `('
../integration/kdevelop/kdewidgets.cpp:234: parse error before `('
../integration/kdevelop/kdewidgets.cpp:236: parse error before `('
../integration/kdevelop/kdewidgets.cpp:238: `KIconView' undeclared (first use this
function)
../integration/kdevelop/kdewidgets.cpp:238: (Each undeclared identifier is reported
only once for each
function it appears in.)
../integration/kdevelop/kdewidgets.cpp:238: `iv' undeclared (first use this function)
../integration/kdevelop/kdewidgets.cpp:238: parse error before `('
../integration/kdevelop/kdewidgets.cpp:240: parse error before `('
../integration/kdevelop/kdewidgets.cpp:243: parse error before `('
../integration/kdevelop/kdewidgets.cpp:245: parse error before `('
../integration/kdevelop/kdewidgets.cpp:247: `KListBox' undeclared (first use this
function)
../integration/kdevelop/kdewidgets.cpp:247: `lb' undeclared (first use this function)
../integration/kdevelop/kdewidgets.cpp:247: parse error before `('
../integration/kdevelop/kdewidgets.cpp:254: `KListView' undeclared (first use this
function)
../integration/kdevelop/kdewidgets.cpp:254: `lv' undeclared (first use this function)
../integration/kdevelop/kdewidgets.cpp:254: parse error before `('
../integration/kdevelop/kdewidgets.cpp:258: parse error before `('
../integration/kdevelop/kdewidgets.cpp:262: parse error before `('
../integration/kdevelop/kdewidgets.cpp:264: parse error before `('
../integration/kdevelop/kdewidgets.cpp:266: parse error before `('
../integration/kdevelop/kdewidgets.cpp:268: parse error before `('
../integration/kdevelop/kdewidgets.cpp:270: parse error before `('
../integration/kdevelop/kdewidgets.cpp:272: `KURLLabel' undeclared (first use this
function)
../integration/kdevelop/kdewidgets.cpp:272: `l' undeclared (first use this function)
../integration/kdevelop/kdewidgets.cpp:272: parse error before `('
../integration/kdevelop/kdewidgets.cpp:282: confused by earlier errors, bailing out
make[5]: *** [../integration/kdevelop/kdewidgets.o] Error 1
make[5]: Leaving directory `/users/cooker/RPM/BUILD/qt-2.3.1/tools/designer/uic'
make[4]: *** [uic] Error 2
make[4]: Leaving directory `/users/cooker/RPM/BUILD/qt-2.3.1/tools/designer'
make[3]: *** [all] Error 2
make[3]: Leaving directory `/users/cooker/RPM/BUILD/qt-2.3.1/tools/designer'
make[2]: *** [designer] Error 2
make[2]: Leaving directory `/users/cooker/RPM/BUILD/qt-2.3.1/tools'
make[1]: *** [all] Error 2
make[1]: Leaving directory `/users/cooker/RPM/BUILD/qt-2.3.1/tools'
make: *** [sub-tools] Error 2
error: Bad exit status from /users/cooker/tmp/rpm-tmp.64753 (%build)
RPM build errors:
Bad exit status from /users/cooker/tmp/rpm-tmp.64753 (%build)
http://d10149.upc-d.chello.nl/build/cooker/urpmi/i586/qt2-2.3.1-8mdk.src.rpm.txt
### Installing: Mesa , Mesa
everything already installed
### Remove following obselete BuildRequires: Mesa-common , Mesa-common
### Installing: Mesa-common-devel , Mesa-common-devel
installing /mirrors/i586/Mandrake/RPMS/XFree86-devel-4.1.0-7mdk.i586.rpm
/mirrors/i586/Mandrake/RPMS/Mesa-common-devel-3.4.2-2mdk.i586.rpm
Preparing... ##################################################
XFree86-devel ##################################################
Mesa-common-devel ##################################################
### Remove following obselete BuildRequires: XFree86-devel , XFree86-devel
### Remove following obselete BuildRequires: XFree86-libs , XFree86-libs
### Installing: XFree86-static-libs , XFree86-static-libs
installing /mirrors/i586/Mandrake/RPMS/XFree86-static-libs-4.1.0-7mdk.i586.rpm
Preparing... ##################################################
XFree86-static-libs ##################################################
### Installing: byacc , byacc
installing /mirrors/i586/Mandrake/RPMS/byacc-1.9-11mdk.i586.rpm
Preparing... ##################################################
byacc ##################################################
### Remove following obselete BuildRequires: db1 , db1
### Installing: db1-devel , db1-devel
installing /mirrors/i586/Mandrake/RPMS/db1-devel-1.85-5mdk.i586.rpm
Preparing... ##################################################
db1-devel ##################################################
### Installing: db3 , db3-utils
installing /mirrors/i586/Mandrake/RPMS/db3-utils-3.2.9-1mdk.i586.rpm
Preparing... ##################################################
db3-utils ##################################################
### Remove following obselete BuildRequires: db3 , libdbtcl3.2
### Remove following obselete BuildRequires: db3 , libdb3.2
### Installing: db3 , libdb3.2-devel
installing /mirrors/i586/Mandrake/RPMS/libdb3.2-devel-3.2.9-1mdk.i586.rpm
Preparing... ##################################################
libdb3.2-devel ##################################################
### Installing: db3 , php-dba_gdbm_db3
installing /mirrors/i586/Mandrake/RPMS/php-dba_gdbm_db3-4.0.6-2mdk.i586.rpm
Installation failed
Try installation without checking dependencies? (y/N) ### Installing: db3-devel ,
libdb3.2-devel
everything already installed
### Installing: flex , flex
installing /mirrors/i586/Mandrake/RPMS/flex-2.5.4a-14mdk.i586.rpm
Preparing... ##################################################
flex ##################################################
### Remove following obselete BuildRequires: gawk , gawk
### Installing: gcc-c++ , gcc-c++
everything already installed
### Remove following obselete BuildRequires: glibc-devel , glibc-devel
### Installing: libbzip2_1-devel , libbzip2_1-devel
installing /mirrors/i586/Mandrake/RPMS/libbzip2_1-devel-1.0.1-13mdk.i586.rpm
Preparing... ##################################################
libbzip2_1-devel ##################################################
### Installing: libjpeg62-devel , libjpeg62-devel
installing /mirrors/i586/Mandrake/RPMS/libjpeg62-devel-6b-20mdk.i586.rpm
Preparing... ##################################################
libjpeg62-devel ##################################################
### Installing: libmng1-devel , libmng1-devel
installing /mirrors/i586/Mandrake/RPMS/libmng1-devel-1.0.2-2mdk.i586.rpm
Preparing... ##################################################
libmng1-devel ##################################################
### Installing: libpng2-devel , libpng2-devel
installing /mirrors/i586/Mandrake/RPMS/libpng2-devel-1.0.12-2mdk.i586.rpm
/mirrors/i586/Mandrake/RPMS/zlib1-devel-1.1.3-15mdk.i586.rpm
Preparing... ##################################################
zlib1-devel ##################################################
libpng2-devel ##################################################
### Remove following obselete BuildRequires: libstdc++-devel , libstdc++2.10-devel
### Installing: libstdc++-devel , libstdc++3.0-devel
installing /mirrors/i586/Mandrake/RPMS/libgcc3.0-3.0.1-0.2mdk.i586.rpm
/mirrors/i586/Mandrake/RPMS/libstdc++3.0-devel-3.0.1-0.2mdk.i586.rpm
/mirrors/i586/Mandrake/RPMS/libstdc++3.0-3.0.1-0.2mdk.i586.rpm
Preparing... ##################################################
libgcc3.0 ##################################################
libstdc++3.0 ##################################################
libstdc++3.0-devel ##################################################
### Installing: libtermcap2-devel , libtermcap2-devel
installing /mirrors/i586/Mandrake/RPMS/libtermcap2-devel-2.0.8-30mdk.i586.rpm
Preparing... ##################################################
libtermcap2-devel ##################################################
### Installing: libungif4-devel , libungif4-devel
installing /mirrors/i586/Mandrake/RPMS/libungif4-devel-4.1.0-14mdk.i586.rpm
Preparing... ##################################################
libungif4-devel ##################################################
### Installing: pam , pam
everything already installed
### Installing: pam-devel , pam-devel
installing /mirrors/i586/Mandrake/RPMS/pam-devel-0.75-6mdk.i586.rpm
Preparing... ##################################################
pam-devel ##################################################
### Installing: popt , popt
everything already installed
### Installing: popt-devel , popt-devel
installing /mirrors/i586/Mandrake/RPMS/popt-devel-1.6.3-0.18mdk.i586.rpm
Preparing... ##################################################
popt-devel ##################################################
### Installing: readline-devel , readline-devel
installing /mirrors/i586/Mandrake/RPMS/readline-devel-4.2-2mdk.i586.rpm
Preparing... ##################################################
readline-devel ##################################################
### Installing: rpm-build , rpm-build
everything already installed
### Remove following obselete BuildRequires: zlib-devel , zlib1-devel
### Remove following obselete BuildRequires: zlib1 , zlib1
### Installing: zlib1 , zlib1
everything already installed
Removing Mesa-common-devel XFree86-devel XFree86-static-libs byacc db1-devel db3-utils
flex libbzip2_1-devel libdb3.2-devel libgcc3.0 libjpeg62-devel libmng1-devel
libpng2-devel libstdc++3.0 libstdc++3.0-devel libtermcap2-devel libungif4-devel
pam-devel popt-devel readline-devel zlib1-devel
I think that clearly shows that there are BuildRequires missing in that
package (it's ugly, qt2 seems to require itself to compile), and some
BuildRequires are redundant (are already required by other BuildRequires
packages).
I hope that one day rpmlint will be able to check src.rpm's for the
redundant BuildRequires... it's not that difficult todo.
>>Having a
>>BuildRequires for kdelibs-devel in the qt2 package is ugly, see below:
>>
>>Take the qt2 package:
>>
>>* Wed Jul 18 2001 David BAUDENS <[EMAIL PROTECTED]> 2.3.1-8mdk
>>
>>- Re-upload with non broken BuildRequires
>>
>>* Wed Jul 18 2001 Stefan van der Eijk <[EMAIL PROTECTED]> 2.3.1-7mdk
>>
>>- BuildRequires: kdelibs-devel
>>- Removed BuildRequires: Mesa-common XFree86-devel XFree86-libs
>> db1 db3 gawk glibc-devel libstdc++-devel zlib-devel zlib1
>>
>>Unfortunatly, the maintainer didn't respond to my emails asking why he
>>changed it back. So I decided to leave BuildRequires on the kde packages
>>as they are now...
>>
>
>I am very happy, thanks don't touch to kde package.
>
I'm sorry, but I'm not too happy, because they're broken... I hope we
can get together & fix the BuildRequires on them.
>You didn't repond a my mail when I ask you why you removed build requires in
>quanta package. I wait again. So ....
>
Is their anything wrong with the BR in the quanta package? It's
compiling fine on my system:
http://d10149.upc-d.chello.nl/build/cooker/i586/OK/quanta-2.1-0.20010414.4mdk.src.rpm.txt
http://d10149.upc-d.chello.nl/build/cooker/urpmi/i586/quanta-2.1-0.20010414.4mdk.src.rpm.txt
>You can break all package if you want but not kde package.
>
>If you touch to kde package you will maintain all kde package, ok ?
>
I don't have the feeling we are being constructive here... I'm positive
that there must be a way to make correct the BuildRequires on the kde
packages and not break the packages at the same time... Shall we work on
that?
with kind regards,
Stefan van der Eijk
