> %install
> -rm -rf $RPM_BUILD_ROOT
> %makeinstall bitsdata=$RPM_BUILD_ROOT/%{_datadir}
>bitssysconf=$RPM_BUILD_ROOT/%{_sysconfdir}
>
> #icons
> @@ -88,12 +121,41 @@
> %{_miconsdir}/%{name}.xpm
> %{_liconsdir}/%{name}.xpm
>
> +%files applet
> +%defattr(-,root,root)
> +%attr(755,root,root) %{prefix}/bin/gaim_applet
> +%doc doc/the_penguin.txt doc/CREDITS NEWS COPYING AUTHORS doc/FAQ README ChangeLog
>plugins/PERL-HOWTO HACKING
> +%{prefix}/lib/gaim/*
> +%{prefix}/share/locale/*/*/*
> +%{prefix}/share/pixmaps/gaim.xpm
> +%{prefix}/share/pixmaps/gaim/*
> +%{prefix}/share/gnome/apps/Internet/gaim.desktop
> +%{sysconfdir}/CORBA/servers/*
> +%{prefix}/share/applets/Network/*
> +
patch is largely ok, just some quick comments on the filelist
gaim_applet should be in applet, that's ok but for the previous main
filelist we have %_bindir/* so we need to changed that. FIXED.
%doc is redundant.
%prefix/lib/gaim/* is redundant since we already have that in previous file
list. FIXED.
ditto for pixmaps and gnome/apps/Internet/gaim.desktop
I think for the CORBA server it should belong in the main filelist no?
the Network applets should be ok.
the %prefix/share/locale is redundant since we have %find_lang already
in the main package.
btw, just to make a quick comment is that you shouldn't really need to
define prefix to /usr -- that was the old way of doing it, these days
there are macros to do this for you like _bindir or _libdir, to see the
full list, you can refer back to the rpm rc files. They're actually
shamelessly ripped from autoconf :)
- G.
