If I recall correctly I did send it to the author, but I could be wrong
(ive slept since then). Ill look at the code as soon as I get a chance...
which I dont forsee happening until this weekend but you never know.
The cause of the problem is that when you remove the files it tries to
lock the mutex to remove the file from the queue. Well if it tries to lock
while the status of the download is updating (the percent, estimated time
to finish etc) it will already be locked.... When you lock a mutex twice
bad things happen. The cure is to call trylock on it and if it fails then
wait and try again. I need to redo the patch anyway because I think I know
of a better way to do it.
-Ry
On Wed, 21 Aug 2002, Geoffrey Lee wrote:
> On Tue, Aug 20, 2002 at 02:40:29PM -0600, Ryan wrote:
> > This is a known bug that has been in gFTP for ages. It is due to some
> > mutex locking issues with threads. I worked on this a while back and had a
> > patch made, im not sure if this patch is still included in the cooker
> > version, furthermore Im not 100% sure if the patch works, but it worked
> > well in my testing.
> >
> > If I get a chance (busy busy) I will check the cooker RPM to see if the
> > patch is included.
>
>
> Yes, that's what I suspected. Mutex bugs.
>
> I think your patch was included. I did a no-brain port to make it
> apply to the latest version though.
>
> btw it would be really good if you can send this to the gftp author
> so that we don't have to potentially port it everytime a new version
> is out ;)
>
>
> -- g.
>
>
--
Ryan
"...Hold on loosely - but dont let go, if you cling too tightly
your gonna lose control." -- 38 Special
"Strange what desire will make foolish people do." -- Chris Isaac
"Today we will try to take over the world!" -- Brain
