On 2002-12-12(Thu) 13:18:02 +0100, G?tz Waschk wrote:
> I think the %configure2_5x macro should be fixed. ATM it expands to:
> [goetz@klama SRPMS]$ rpm --eval %configure2_5x
> 
>   CONFIGURE_TOP="${CONFIGURE_TOP:-.}";
>   CFLAGS="${CFLAGS:--O2 -fomit-frame-pointer -pipe -march=i586 -mcpu=pentiumpro\}" ; 
>export CFLAGS ;
>   CXXFLAGS="${CXXFLAGS:--O2 -fomit-frame-pointer -pipe -march=i586 
>-mcpu=pentiu\mpro}" ; export CXXFLAGS ;
>   FFLAGS="${FFLAGS:--O2 -fomit-frame-pointer -pipe -march=i586 -mcpu=pentiumpro\}" ; 
>export FFLAGS ;
>   (cd $CONFIGURE_TOP; [ -f configure.in ] && libtoolize --copy --force) ;
> 
> [schnipp]
> 
> With autoconf 2.5 the autoconf file can be named configure.ac instead
> of configure.in. So the libtoolize call should check also check for
> configure.ac

Yup, though not many packages uses configure.ac solely, I think rpm
maintainer (flepied?) should consider adding this bit now.

Yet another problem:

[...snip...]
$CONFIGURE_TOP/configure --build %{_target_platform} --host
%{_target_platform} --target %{_target_platform} \\\
[...snip...]

Adding --host and --target will put autoconf 2.5x into cross compile
mode. The result is, some packages will contain funny named binaries
such as "i586-mandrake-linux-foobar", and need to use ugly hacks to fix
it. It's good for all to turn --host and --target off. This has been
discussed in various places, I think.

-- 
GPG Key: (0xC67186FF) http://deaddog.org/gpg.asc

Attachment: msg84188/pgp00000.pgp
Description: PGP signature

Reply via email to