Finally, Andrey send me a fix for supermount. I will probably also merge this with my kernel on the club, unless an official update is released?
happy new year to you all:)
Danny
---------- Forwarded Message ----------
From: "������" <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED],[EMAIL PROTECTED]
Date: Wed, 01 Jan 2003 16:39:59 +0300
> Attached is combined supermount patch for 2.4.20-2mdk that fixes
> all known to me bugs. Danny, would you forward this to cooker?
> This way it has some chances of being resubmitted if lost :))
> Juan, if some parts are not accepted, please let me know.
>
> Here is list of fixes:
>
> 1. Fix space reclaim problem on FAT
>
> The problem was actually in FAT itself. Space is reclaimed when
> inode is finally destroyed and at this time subfs is already remounted
> read-only. But fs/fs/file.c:fat_truncate() silently refused to work
> on read-only file system. IMHO this check is redundant so the patch
> just removes it. Please, let me know if any porblem comes out of it.
>
> 2. Fix "no such file" on recursive copy
>
> The bug was introduced in 2.4.19-12mdk in attempt to fix #1 :-)
> Unfortunately, it caused subfs dentries to never be released even
> when subfs inodes went away. Next time file was looked up, dentry
> without inode was returned and this was interpreted by VFS layer as
> "no such file or directory". The bug was nasty to trace because
> no error was actually seen on supermount layer.
>
> 3. Fix rare case of media revalidation not working
>
> This has been reported ages ago and I have sent patch ages ago as well.
> The bug happens when device is accessed before supermount on media
> change (to reproduce - ls /mnt/cdrom, change CD and _manually_ close
> tray, do eject -t, do ls /mnt/cdrom. You get very interesting results).
> This is not as innocent as it looks like, it can happen in real life.
> The patch adds "media change" flag to superblock that is set on
> media change query and is used by supermount.
>
> 4. Cannot always use NLS mount options on auto fs type
>
> Again old patch that just adds support for (dummy) flags to ext2 and
> udf filesystems so that NLS options can safely be used with auto type.
>
> 5. Fix SEGFAULT on wrong mount option
>
> Side effect of changes in 2.4.19-12mdk. Goes away with #2.
>
> 6. Really free sbi and root dentry/inode
>
> Probably negligible in real life (normal users just mount supermounted
> file systems once) it makes the above be really freed on umount.
>
> Danny, your last problem - "invalid argument" after cd /mnt/cdrom,
> ejecting and reinserting CD, ls . is not a bug - it is a feature :-)
> After CD has been ejected all file information is invalidated. So your
> current directory does not exist anymore. The same as in case of
> somebody removing directory on NFS server. So the patch changes
> error to ESTALE in this case (it is more appropriate). Just do cd /;
> cd /mnt/cdrom and you can use CD again.
>
> Folks I am sorry I am not currently on cooker for many reasons so
> if any problems come out of this patch please let me know. Danny,
> keep watch if this is really applied :)))
>
> cheers
>
> -andrey
>
>
> ATTACHMENT: application/x-patch ("2.4.20-2mdk.supermount.patch")
-------------------------------------------------------
2.4.20-2mdk.supermount.patch
Description: Binary data
