svn commit: r743045 - in /hadoop/core/trunk: CHANGES.txt src/hdfs/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java

[shv]

Author: shv
Date: Tue Feb 10 18:34:43 2009
New Revision: 743045

URL: http://svn.apache.org/viewvc?rev=743045&view=rev
Log:
HADOOP-5127. Remove public methods in FSDirectory. Contributed by Jakob Homan.

Modified:
    hadoop/core/trunk/CHANGES.txt
    
hadoop/core/trunk/src/hdfs/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java

Modified: hadoop/core/trunk/CHANGES.txt
URL: 
http://svn.apache.org/viewvc/hadoop/core/trunk/CHANGES.txt?rev=743045&r1=743044&r2=743045&view=diff
==============================================================================
--- hadoop/core/trunk/CHANGES.txt (original)
+++ hadoop/core/trunk/CHANGES.txt Tue Feb 10 18:34:43 2009
@@ -759,6 +759,8 @@
 
     HADOOP-5126. Remove empty file BlocksWithLocations.java (shv)
 
+    HADOOP-5127. Remove public methods in FSDirectory. (Jakob Homan via shv)
+
   BUG FIXES
 
     HADOOP-4697. Fix getBlockLocations in KosmosFileSystem to handle multiple

Modified: 
hadoop/core/trunk/src/hdfs/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
URL: 
http://svn.apache.org/viewvc/hadoop/core/trunk/src/hdfs/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java?rev=743045&r1=743044&r2=743045&view=diff
==============================================================================
--- 
hadoop/core/trunk/src/hdfs/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
 (original)
+++ 
hadoop/core/trunk/src/hdfs/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
 Tue Feb 10 18:34:43 2009
@@ -48,18 +48,18 @@
   final FSNamesystem namesystem;
   final INodeDirectoryWithQuota rootDir;
   FSImage fsImage;  
-  boolean ready = false;
+  private boolean ready = false;
   // Metrics record
   private MetricsRecord directoryMetrics = null;
 
   /** Access an existing dfs name directory. */
-  public FSDirectory(FSNamesystem ns, Configuration conf) {
+  FSDirectory(FSNamesystem ns, Configuration conf) {
     this(new FSImage(), ns, conf);
     fsImage.setCheckpointDirectories(FSImage.getCheckpointDirs(conf, null),
                                 FSImage.getCheckpointEditsDirs(conf, null));
   }
 
-  public FSDirectory(FSImage fsImage, FSNamesystem ns, Configuration conf) {
+  FSDirectory(FSImage fsImage, FSNamesystem ns, Configuration conf) {
     rootDir = new INodeDirectoryWithQuota(INodeDirectory.ROOT_NAME,
         ns.createFsOwnerPermissions(new FsPermission((short)0755)),
         Integer.MAX_VALUE, -1);
@@ -497,7 +497,7 @@
    * @return the number of bytes 
    * @throws IOException if it is a directory or does not exist.
    */
-  public long getPreferredBlockSize(String filename) throws IOException {
+  long getPreferredBlockSize(String filename) throws IOException {
     synchronized (rootDir) {
       INode fileNode = rootDir.getNode(filename);
       if (fileNode == null) {
@@ -562,7 +562,7 @@
   /**
    * Remove the file from management, return blocks
    */
-  public INode delete(String src) {
+  INode delete(String src) {
     if (NameNode.stateChangeLog.isDebugEnabled()) {
       NameNode.stateChangeLog.debug("DIR* FSDirectory.delete: "+src);
     }
@@ -576,8 +576,8 @@
   }
   
   /** Return if a directory is empty or not **/
-  public boolean isDirEmpty(String src) {
-       boolean dirNotEmpty = true;
+  boolean isDirEmpty(String src) {
+          boolean dirNotEmpty = true;
     if (!isDir(src)) {
       return true;
     }
@@ -699,7 +699,7 @@
    * This function is admittedly very inefficient right now.  We'll
    * make it better later.
    */
-  public FileStatus[] getListing(String src) {
+  FileStatus[] getListing(String src) {
     String srcs = normalizePath(src);
 
     synchronized (rootDir) {
@@ -788,7 +788,7 @@
   /** 
    * Check whether the filepath could be created
    */
-  public boolean isValidToCreate(String src) {
+  boolean isValidToCreate(String src) {
     String srcs = normalizePath(src);
     synchronized (rootDir) {
       if (srcs.startsWith("/") && 
@@ -804,7 +804,7 @@
   /**
    * Check whether the path specifies a directory
    */
-  public boolean isDir(String src) {
+  boolean isDir(String src) {
     synchronized (rootDir) {
       INode node = rootDir.getNode(normalizePath(src));
       return node != null && node.isDirectory();