[
https://issues.apache.org/jira/browse/HADOOP-2668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12561200#action_12561200
]
stack commented on HADOOP-2668:
-------------------------------
This patch looks great.
Shouldn't the 'check' emit a result? That is, shouldn't check say
"hbase.rootdir is up to date" or "hbase.rootdir needs to be migrated"? Same
for actual migration. Should say "migration successful" or "migration failed"
or "up to date"?
Regards the check for a running cluster, what we've seen internally is that
often a newer version of hbase will just timeout trying to connect to a running
instance without an exception being thrown or complaint about mismatched RPC
version numbers. There ain't much that the migration script can do in this
case. Add to the info log a more forceful note that hbase cluster must be down
when this script runs?
If the HDFS to upgrade is not running, it doesn't recognize it. See below:
{code}
[EMAIL PROTECTED] hbase]$ ./bin/hbase migrate check
08/01/22 02:11:35 INFO util.Migrate: Verifying that HBase is not running...
08/01/22 02:11:35 INFO ipc.Client: Retrying connect to server:
XX.XX.XX.139:60000. Already tried 1 time(s).
08/01/22 02:11:36 INFO ipc.Client: Retrying connect to server:
XX.XX.XX.139:60000. Already tried 2 time(s).
...
08/01/22 02:11:45 INFO util.Migrate: Starting migration check
08/01/22 02:11:45 INFO ipc.Client: Retrying connect to server:
XX.XX.XX.139:9123. Already tried 1 time(s).
....
{code}
I don't think this too important.
> [hbase] Documentation and improved logging so fact that hbase now requires
> migration comes as less of a surprise
> ----------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-2668
> URL: https://issues.apache.org/jira/browse/HADOOP-2668
> Project: Hadoop
> Issue Type: Bug
> Components: contrib/hbase
> Affects Versions: 0.16.0
> Reporter: stack
> Assignee: Jim Kellerman
> Priority: Blocker
> Fix For: 0.16.0
>
> Attachments: migrate.patch, migration.patch, patch.txt
>
>
> Hbase now checks for a version file. If none, it reports a version mismatch.
> There will be no version file if the hbase was made by a version older than
> r613469
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
