[ 
https://issues.apache.org/jira/browse/HADOOP-2092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12561953#action_12561953
 ] 

amareshwari edited comment on HADOOP-2092 at 1/24/08 1:29 AM:
---------------------------------------------------------------------------

bq. Please add locking around the isDone method in the context and updating the 
done flag.

Do we really need a lock here? Since, boolean is one byte memory and ping 
thread only reads it. Ping thread can read a stale value, since in the next 
iteration it will read the correct value.
Without doing a lock, we save the "lock" overhead.

      was (Author: amareshwari):
    bq. Please add locking around the isDone method in the context and updating 
the done flag.

Do we really need a lock here? Since, boolean is one byte memory and ping 
thread only reads it. Ping thread can read a stale value, since in the next 
iteration it will read the correct value.
  
> Pipes C++ task does not die even if the Java tasks die
> ------------------------------------------------------
>
>                 Key: HADOOP-2092
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2092
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: pipes
>            Reporter: Amareshwari Sri Ramadasu
>            Assignee: Amareshwari Sri Ramadasu
>            Priority: Blocker
>             Fix For: 0.16.0
>
>         Attachments: patch-2092.1.txt, patch-2092.1.txt, patch-2092.txt, 
> patch-2092.txt, patch-2092.txt, patch-2092.txt
>
>
> Pipes process does not die, when the java map task  dies.
> Pipes process does not die even when the cluster is down.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to