[ 
https://issues.apache.org/jira/browse/HADOOP-2718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12563619#action_12563619
 ] 

Hadoop QA commented on HADOOP-2718:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12374212/conf.patch
against trunk revision 615723.

    @author +1.  The patch does not contain any @author tags.

    javadoc +1.  The javadoc tool did not generate any warning messages.

    javac +1.  The applied patch does not generate any new javac compiler 
warnings.

    release audit +1.  The applied patch does not generate any new release 
audit warnings.

    findbugs +1.  The patch does not introduce any new Findbugs warnings.

    core tests +1.  The patch passed core unit tests.

    contrib tests +1.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1699/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1699/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1699/artifact/trunk/build/test/checkstyle-errors.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1699/console

This message is automatically generated.

> Copy Constructor HBaseConfiguration(Configuration) will override hbase 
> configurations if argumant is not an instance of HBaseConfiguration.
> -------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-2718
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2718
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: contrib/hbase
>            Reporter: Clint Morgan
>            Priority: Blocker
>             Fix For: 0.16.0
>
>         Attachments: conf.patch
>
>
> Copy Constructor HBaseConfiguration(Configuration) will override hbase
> settings from the argument if the arg is not an instance of 
> HBaseConfiguration.
> This was happening to me when I was passing around hbase settings as
> part of a Table Map/Reduce job configuration.
> Observer the following unexpected behavior:
> JobConf jobConf = new JobConf("job.xml");
> HBaseConfiguration hbaseConf = new HBaseConfiguration(jobConf);
> String result1 = jobConf.get("hbase.master");  // Value from job.xml loaded 
> by tasktracker
> String result2 = hbaseConf.get("hbase.master"); // Value from hbase-site.xml
> Assert.assertEquals(result1, result2); // Fail 
> In particular, this copy constructor is called in 
> hbase.mapred.TableInputFormat.configure(JobConf).
> I have a hbase.master defined in my JobConf that gets overridden in the 
> HbaseConfiguration by hbase-site.xml.
> Should the Constructor instead add new hbase-specific values if they are not 
> already defined in the Configuration parameter?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to