[
https://issues.apache.org/jira/browse/HADOOP-2738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12564178#action_12564178
]
Hadoop QA commented on HADOOP-2738:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12374406/patch.txt
against trunk revision 616796.
@author +1. The patch does not contain any @author tags.
javadoc +1. The javadoc tool did not generate any warning messages.
javac +1. The applied patch does not generate any new javac compiler
warnings.
release audit +1. The applied patch does not generate any new release
audit warnings.
findbugs +1. The patch does not introduce any new Findbugs warnings.
core tests +1. The patch passed core unit tests.
contrib tests +1. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1713/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1713/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1713/artifact/trunk/build/test/checkstyle-errors.html
Console output:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1713/console
This message is automatically generated.
> Text is not subclassable because set(Text) and compareTo(Object) access the
> other instance's private members directly
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-2738
> URL: https://issues.apache.org/jira/browse/HADOOP-2738
> Project: Hadoop Core
> Issue Type: Bug
> Components: io
> Affects Versions: 0.16.0
> Reporter: Jim Kellerman
> Assignee: Jim Kellerman
> Priority: Minor
> Fix For: 0.17.0
>
> Attachments: patch.txt
>
>
> Text objects should not access other Text objects private members directly.
> Both set(Text) and compareTo(Object) do.
> Because these two methods access private members of the other object, Text is
> not subclassable. Either these two methods should be modified to use the
> accessors that are already available, or Text should be declared as a final
> class, because as it exists today it is not subclassable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
