[ 
https://issues.apache.org/jira/browse/HADOOP-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12564562#action_12564562
 ] 

Doug Cutting commented on HADOOP-2754:
--------------------------------------

> Doug, do you mind if I open a new jira on this idea?

I think composition is required to fix this issue.  listStatus(Path, 
PathFilter) when applied to a CheckSumFileSystem should filter both for .crc 
files and for the user-specified PathFilter.  That means something like:

{noformat}
public FileStatus[] CheckSumFileSystem#listStatus(Path p, final PathFilter 
filter) throws IOException {
  fs.listStatus(p, new PathFilter() {
      public boolean accept(Path file) {
        return (!isChecksumFile(file) && filter.accept(file));
      }
    };
}
{noformat}
i.e., composing the filters.


> Path filter for Local file system list .crc files
> -------------------------------------------------
>
>                 Key: HADOOP-2754
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2754
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>            Reporter: Amareshwari Sri Ramadasu
>            Assignee: Hairong Kuang
>             Fix For: 0.16.1
>
>
> If we write a path filter for local file system, it  lists .crc files also.
> If dont pass any filter, it lists paths properly without any .crc files. But 
> we write a filter, it does list .crc files also.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to