[
https://issues.apache.org/jira/browse/HADOOP-2599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12564591#action_12564591
]
Hadoop QA commented on HADOOP-2599:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12374516/2599-v2.patch
against trunk revision 616796.
@author +1. The patch does not contain any @author tags.
javadoc +1. The javadoc tool did not generate any warning messages.
javac +1. The applied patch does not generate any new javac compiler
warnings.
release audit +1. The applied patch does not generate any new release
audit warnings.
findbugs +1. The patch does not introduce any new Findbugs warnings.
core tests +1. The patch passed core unit tests.
contrib tests +1. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1718/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1718/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1718/artifact/trunk/build/test/checkstyle-errors.html
Console output:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1718/console
This message is automatically generated.
> [hbase] Some minor improvements to changes in HADOOP-2443
> ---------------------------------------------------------
>
> Key: HADOOP-2599
> URL: https://issues.apache.org/jira/browse/HADOOP-2599
> Project: Hadoop Core
> Issue Type: Improvement
> Components: contrib/hbase
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Minor
> Fix For: 0.17.0
>
> Attachments: 2599-v2.patch, 2599.patch
>
>
> Stack made a number of suggestions for improvements in the code changes from
> HADOOP-2443:
> Here in HConnectionManager:
> + scannerId = server.openScanner(
> + metaLocation.getRegionInfo().getRegionName(),
> + COLUMN_FAMILY_ARRAY, EMPTY_START_ROW, LATEST_TIMESTAMP,
> + null);
> ... EMPTY_START_ROW will work but 'startRow' would be easier to read (It'd
> work too - right?).
> Here:
> + } while (startRow.compareTo(EMPTY_START_ROW) != 0);
> .. EMPTY_ROW or a new define, LAST_ROW, would have been more readable, don't
> you think?
> This 999... 'trick' should be done as a method - in HTableInfo? - since you
> do it twice:
> + Text tableKey = new Text(tableName.toString() + ",,99999999999999");
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
