[
https://issues.apache.org/jira/browse/HADOOP-2767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12565998#action_12565998
]
Hadoop QA commented on HADOOP-2767:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12374834/excludedLeaf4.patch
against trunk revision 616796.
@author +1. The patch does not contain any @author tags.
javadoc +1. The javadoc tool did not generate any warning messages.
javac +1. The applied patch does not generate any new javac compiler
warnings.
release audit +1. The applied patch does not generate any new release
audit warnings.
findbugs +1. The patch does not introduce any new Findbugs warnings.
core tests +1. The patch passed core unit tests.
contrib tests +1. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1747/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1747/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1747/artifact/trunk/build/test/checkstyle-errors.html
Console output:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1747/console
This message is automatically generated.
> org.apache.hadoop.net.NetworkTopology.InnerNode#getLeaf does not return the
> last node on a rack when used with an excluded node
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-2767
> URL: https://issues.apache.org/jira/browse/HADOOP-2767
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.15.3
> Reporter: Mark Butler
> Assignee: Hairong Kuang
> Priority: Minor
> Fix For: 0.17.0
>
> Attachments: excludedLeaf.patch, excludedLeaf2.patch,
> excludedLeaf3.patch, excludedLeaf4.patch, NetworkTopologyTest.java
>
>
> I have written some test code that shows NetworkTopology.InnerNode#getLeaf
> will never return the last node on the rack if it is called with an
> excludedNode (for example the first node on the rack).
> Consequently I suspect that NetworkTopology.chooseRandom() will never returns
> the last node on the remote rack for the second replica in DFS.
> I have some test code that demonstrates this problem at the getLeaf level,
> although it is necessary to change the visibility of the
> NetworkTopology.InnerNode, NetworkTopology.InnerNode#getLeaf and
> NetworkTopology.getNode from private to package default to run the test.
> TODO: Demonstrate problem at NetworkTopology.chooseRandom level, then submit
> candidate fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
