[ 
https://issues.apache.org/jira/browse/HADOOP-2832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12569069#action_12569069
 ] 

Tsz Wo (Nicholas), SZE commented on HADOOP-2832:
------------------------------------------------

Thanks for fixing the indentation.  Below are my comments:

- the indentation still not correct in ResponseProcessor.run(), there are 4 
spaces (instead of 2 spaces) after "try {".

- could you also remove a un-used local variable "int numTargets = -1;"?


> bad code indentation in DFSClient
> ---------------------------------
>
>                 Key: HADOOP-2832
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2832
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>            Reporter: dhruba borthakur
>            Assignee: dhruba borthakur
>             Fix For: 0.17.0
>
>         Attachments: 2832.patch
>
>
> A few lines of code in DFSClient are mis-indented because of the presence of 
> tabs. The tabs should be removed. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to