[ 
https://issues.apache.org/jira/browse/HADOOP-2866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12572658#action_12572658
 ] 

Doug Cutting commented on HADOOP-2866:
--------------------------------------

> Doug: I meant by using the manual get()/set() methods - not through a 
> specific accessor method [...]

I don't have a proposal for how to catch those automatically.  But we can clean 
up the core code considerably, providing a much better example for user code to 
model.

> do you have particular names for these methods in mind?

The style I prefer is to add static methods to the most relevant public class.  
Examples of these are:
- SequenceFile#get/setCompressionType
- DistributedCache#setCacheArchives. et al
- SequenceFileInputFilter#setFilterClass et al
- HADOOP-1967

Perhaps we should add annotations to such accessor methods, naming the 
parameter that the get or set, then we could use 'apt', the annotation 
processor, to build a list of all of these for the documentation?

> JobConf should validate key names in well-defined namespaces and warn on 
> misspelling
> ------------------------------------------------------------------------------------
>
>                 Key: HADOOP-2866
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2866
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: mapred
>    Affects Versions: 0.16.0
>            Reporter: Aaron Kimball
>            Priority: Minor
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> A discussion on the mailing list reveals that some configuration strings in 
> the JobConf are deprecated over time and new configuration names replace them:
> e.g., "mapred.output.compression.type" is now replaced with 
> "mapred.map.output.compression.type"
> Programmers who have been manually specifying the former string, however, 
> receive no diagnostic output during testing to suggest that their compression 
> type is being silently ignored.
> It would be desirable to notify developers of this change by printing a 
> warning message when deprecated configuration names are used in a newer 
> version of Hadoop. More generally, when any configuration string in the 
> mapred.\*, fs.\*, dfs.\*, etc namespaces are provided by a user and are not 
> recognized by Hadoop, it is desirable to print a warning, to indicate 
> malformed configurations. No warnings should be printed when configuration 
> keys are in user-defined namespaces (e.g., "myprogram.mytask.myvalue").

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to