[ 
https://issues.apache.org/jira/browse/HADOOP-2870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12575871#action_12575871
 ] 

Raghu Angadi commented on HADOOP-2870:
--------------------------------------

> Move client.stop out of the critical section in stopClient

stopClient() is still synchronized at the top.

I haven't entirely thought through it, but it would be nice if RPC.stopProxy() 
could take RetryProxy (which is a wrapper around regular Proxy) as well. That 
way users don't need to distinguish these two. Right now DataNode has to 
proxies 'namenode' for RPCs and 'rpcNamenode' for stopProxy().
 

> Datanode.shutdown() and Namenode.stop() should close all rpc connections
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-2870
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2870
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: ipc
>    Affects Versions: 0.16.0
>            Reporter: Hairong Kuang
>            Assignee: Hairong Kuang
>             Fix For: 0.17.0
>
>         Attachments: closeConnection.patch, closeConnection1.patch
>
>
> Currently this two cleanup methods do not close all existing rpc connections. 
> If a mini dfs cluster gets shutdown and then restarted as we do in 
> TestFileCreation, RPCs in second mini cluster reuse the unclosed connections 
> opened in the first run but there is no server running to serve the request. 
> So the client get stuck waiting for the response forever if client side 
> timeout gets removed as suggested by hadoop-2811.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to