[
https://issues.apache.org/jira/browse/HADOOP-2423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12577271#action_12577271
]
Konstantin Shvachko commented on HADOOP-2423:
---------------------------------------------
+1
I am only worried about limit 0 in String.split(). There was a reason for -1,
which I don't remember now,
but could you please verify some corner cases, like creating a file/directory
in the root, probably renaming, etc..
> The codes in FSDirectory.mkdirs(...) is inefficient.
> ----------------------------------------------------
>
> Key: HADOOP-2423
> URL: https://issues.apache.org/jira/browse/HADOOP-2423
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.15.1
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: 2423_20080130.patch, 2423_20080303.patch,
> 2423_20080304.patch, 2423_20080304b.patch, 2423_20080304c.patch,
> 2423_20080304d.patch, 2423_20080310.patch
>
>
> FSDirectory.mkdirs(...) creates List<String> v to store all dirs. e.g.
> {code}
> //Suppose
> src = "/foo/bar/bas/"
> //Then,
> v = {"/", "/foo", "/foo/bar", "/foo/bar/bas"}
> {code}
> For each directory string *cur* in v, no matter *cur* already exists or not,
> it will try to do a unprotectedMkdir(cur, ...). Then, *cur* is parsed to
> byte[][] in INodeDirectory.addNode (...).
> We don't need to do the parsing for each string in v. Instead, byte[][]
> should be stored. Also, the loop should not continue once it finds an
> existing subdirectory.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
