[ 
https://issues.apache.org/jira/browse/HADOOP-3033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12580191#action_12580191
 ] 

Tsz Wo (Nicholas), SZE commented on HADOOP-3033:
------------------------------------------------

+1 codes look good

Some minor comments:
- It might be better to use ackQueue lock instead of PacketResponder.this for 
ackQueue related synchronization.

- Should check LOG.isDebugEnabled() before printing debug messages.  Then the 
message will not be constructed (i.e. better performance) if debug is not 
enabled.

> Datanode fails write to DFS file with exception message "Trying to change 
> block file offset"
> --------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-3033
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3033
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.16.1
>            Reporter: dhruba borthakur
>            Assignee: dhruba borthakur
>         Attachments: badnode.patch, badnode2.patch
>
>
> A write to a DFS block failed with the lastdatanode in the pipeline reporting 
> this error:
> Receiving block blk_-7279084187433655573 src: /xx.xx.xx.xx:xx dest: 
> /xx.xx.xx.xx:50010
> Changing block file offset of block blk_-7279084187433655573 from 9043968 to 
> 9043968 meta file offset to 70663
> Changing block file offset of block blk_-7279084187433655573 from 111935488 
> to 112001024 meta file offset to 875015
> Exception in receiveBlock for block blk_-7279084187433655573 
> java.io.IOException: Trying to change block file offset of block 
> blk_-7279084187433655573 to 112001024 but actual size of file is 111935488
> PacketResponder 0 for block blk_-7279084187433655573 Interrupted.
> PacketResponder 0 for block blk_-7279084187433655573 terminating
> writeBlock blk_-7279084187433655573 received exception java.io.IOException: 
> Trying to change block file offset of block blk_-7279084187433655573 to 
> 112001024 but actual size of file is 111935488
> DataXceiver: java.io.IOException: Trying to change block file offset of block 
> blk_-7279084187433655573 to 112001024 but actual size of file is 111935488

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to