[ 
https://issues.apache.org/jira/browse/HADOOP-2783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vinod Kumar Vavilapalli updated HADOOP-2783:
--------------------------------------------

    Attachment: HADOOP-2783.2

The concerned code path raising HodInterruptedException is traversed when any 
rpc method returns an exception and by that time hod interrupt is set. To test 
this method, we need to mimic a user given keyboard interrupt, which doesn't 
seem possible/straight-forward because of threading issues. So falling back to 
indirect way of testing the patch - 1) setting interrupt  even before calling 
rpc method and 2) let calling rpc method return an exception by giving invalid 
rpc host address. (2) could also have been done by having a rpc method that 
simply raises an exception.

> hod/hodlib/Common/xmlrpc.py uses HodInterruptException without importing it
> ---------------------------------------------------------------------------
>
>                 Key: HADOOP-2783
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2783
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: contrib/hod
>    Affects Versions: 0.16.0, 0.16.1, 0.17.0
>            Reporter: Vinod Kumar Vavilapalli
>            Assignee: Vinod Kumar Vavilapalli
>            Priority: Minor
>             Fix For: 0.17.0
>
>         Attachments: HADOOP-2783, HADOOP-2783.1, HADOOP-2783.2
>
>
> And because of this no-import of HodInterruptException in 
> hod/hodlib/Common/xmlrpc.py, HOD fails with an exception, when it gets 
> interrupted by user(e.g ^C) while it is performing any xmlrpc request. One 
> line fix.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to