[
https://issues.apache.org/jira/browse/HADOOP-3046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12581755#action_12581755
]
Hadoop QA commented on HADOOP-3046:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12378526/3046-2.patch
against trunk revision 619744.
@author +1. The patch does not contain any @author tags.
tests included +1. The patch appears to include 3 new or modified tests.
javadoc +1. The javadoc tool did not generate any warning messages.
javac +1. The applied patch does not generate any new javac compiler
warnings.
release audit +1. The applied patch does not generate any new release
audit warnings.
findbugs +1. The patch does not introduce any new Findbugs warnings.
core tests +1. The patch passed core unit tests.
contrib tests +1. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2041/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2041/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2041/artifact/trunk/build/test/checkstyle-errors.html
Console output:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2041/console
This message is automatically generated.
> Text and BytesWritable's raw comparators should use the lengths provided
> instead of rebuilding them from scratch using readInt
> ------------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-3046
> URL: https://issues.apache.org/jira/browse/HADOOP-3046
> Project: Hadoop Core
> Issue Type: Improvement
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: 3046-2.patch, 3046.patch
>
>
> It would be much faster to use the key length provided by the raw compare
> function rather than rebuilding the integer lengths back up from bytes twice
> for every comparison in the sort.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
