[ 
https://issues.apache.org/jira/browse/HADOOP-2855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12582253#action_12582253
 ] 

Hemanth Yamijala commented on HADOOP-2855:
------------------------------------------

Code and tests looks good. Works with relative paths correctly.

Could we have added a test for checking relative path expansion, that 
normalization actually expands the relative path ? Maybe create a tmp file in 
the current directory (which is the original directory), chdir to /tmp, 
normalize, verify that the tmp file is normalized to the full path in the 
original directory, then chdir back to the original directory. Would that work ?

Apart from this, +1.

> [HOD] HOD fails to allocate a cluster if the tarball specified is a relative 
> path
> ---------------------------------------------------------------------------------
>
>                 Key: HADOOP-2855
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2855
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: contrib/hod
>    Affects Versions: 0.16.0
>            Reporter: Hemanth Yamijala
>            Assignee: Vinod Kumar Vavilapalli
>            Priority: Blocker
>             Fix For: 0.17.0
>
>         Attachments: HADOOP-2855, HADOOP-2855.1
>
>
> Run hod -t my-tar.tar.gz -o "allocate hod-cluster 3". Ringmaster fails to 
> come up. The log shows the exception as an invalid URL for the tarball file. 
> Basically HOD should translate the relative path to an absolute path and send 
> it to the ringmaster.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to