[ 
https://issues.apache.org/jira/browse/HADOOP-3128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12583239#action_12583239
 ] 

Nigel Daley commented on HADOOP-3128:
-------------------------------------

>From test-patch:

     [exec] -1 overall.
     [exec]
     [exec]     @author +1.  The patch does not contain any @author tags.
     [exec]
     [exec]     tests included -1.  The patch doesn't appear to include any new 
or modified tests.
     [exec]                         Please justify why no tests are needed for 
this patch.
     [exec]
     [exec]     javadoc +1.  The javadoc tool did not generate any warning 
messages.
     [exec]
     [exec]     javac +1.  The applied patch does not generate any new javac 
compiler warnings.
     [exec]
     [exec]     findbugs +1.  The patch does not introduce any new Findbugs 
warnings.

An existing test caught this problem: TestDFSPermission



> TestDFSPermission due to not throwing exception.
> ------------------------------------------------
>
>                 Key: HADOOP-3128
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3128
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.16.2
>            Reporter: Konstantin Shvachko
>            Assignee: Konstantin Shvachko
>             Fix For: 0.16.2
>
>         Attachments: TestDFSPermission.patch
>
>
> This is the consequence of HADOOP-3108.
> setPermission nad setOwner should throw RemoteException if it is not 
> FileNotFoundException.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to