[
https://issues.apache.org/jira/browse/HADOOP-2634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12584807#action_12584807
]
Konstantin Shvachko commented on HADOOP-2634:
---------------------------------------------
# Filesystem.exists() can return true even if getFileStatus() returns null.
We so not know about all file systems how they implement exists, so I would do
{code}
return getFileStatus() != null;
{code}
# Same in DFSClient.exists().
The rest looks good. +1
> Deprecate exists() and isDir() to simplify ClientProtocol.
> ----------------------------------------------------------
>
> Key: HADOOP-2634
> URL: https://issues.apache.org/jira/browse/HADOOP-2634
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.15.0
> Reporter: Konstantin Shvachko
> Assignee: lohit vijayarenu
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: HADOOP-2634-1.patch
>
>
> ClientProtocol can be simplified by removing two methods
> {code}
> public boolean exists(String src) throws IOException;
> public boolean isDir(String src) throws IOException;
> {code}
> This is a redundant api, which can be implemented in DFSClient as convenience
> methods using
> {code}
> public DFSFileInfo getFileInfo(String src) throws IOException;
> {code}
> Note that we already deprecated several Filesystem method and advised to use
> getFileStatus() instead.
> Should we deprecate them in 0.16?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
