[ 
https://issues.apache.org/jira/browse/HADOOP-3139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12585356#action_12585356
 ] 

Konstantin Shvachko commented on HADOOP-3139:
---------------------------------------------

+1
The important thing is that the deadlock problem is solved.
It turned out to be that the only way to get rid of the warning is to remove 
the verification itself.
The problem here is that people keep using configuration class as a container 
for passing
parameters between methods, which is a bad practice.


> DistributedFileSystem.close() deadlock and FileSystem.closeAll() warning
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-3139
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3139
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Blocker
>             Fix For: 0.16.3, 0.17.0
>
>         Attachments: 3139_20080331.patch, 3139_20080402b.patch, 
> 3139_20080403.patch
>
>
> Koji found the following:
> *DistributedFileSystem.close() deadlock*
> My dfs -ls hang. 
> Ctrl-Z showed a deadlock state.
> {noformat}
> "Thread-0":
>         at 
> org.apache.hadoop.dfs.DistributedFileSystem.close(DistributedFileSystem.java:190)
>         - waiting to lock <0xedde8788> (a 
> org.apache.hadoop.dfs.DistributedFileSystem)
>         at 
> org.apache.hadoop.fs.FileSystem$Cache.closeAll(FileSystem.java:1231)
>         - locked <0xee0baf88> (a org.apache.hadoop.fs.FileSystem$Cache)
>         at org.apache.hadoop.fs.FileSystem.closeAll(FileSystem.java:169)
>         at 
> org.apache.hadoop.fs.FileSystem$ClientFinalizer.run(FileSystem.java:154)
>         - locked <0xee0bae40> (a 
> org.apache.hadoop.fs.FileSystem$ClientFinalizer)
> "main":
>         at org.apache.hadoop.fs.FileSystem$Cache.remove(FileSystem.java:1201)
>         - waiting to lock <0xee0baf88> (a 
> org.apache.hadoop.fs.FileSystem$Cache)
>         at org.apache.hadoop.fs.FileSystem.close(FileSystem.java:1085)
>         at 
> org.apache.hadoop.dfs.DistributedFileSystem.close(DistributedFileSystem.java:192)
>         - locked <0xedde8788> (a org.apache.hadoop.dfs.DistributedFileSystem)
>         at org.apache.hadoop.fs.FsShell.close(FsShell.java:1698)
>         at org.apache.hadoop.fs.FsShell.main(FsShell.java:1712)
> Found 1 deadlock.
> {noformat}
> *FileSystem.closeAll() warning*
> {noformat}
> 08/03/31 16:48:42 INFO fs.FileSystem: FileSystem.closeAll() threw an 
> exception:
> java.io.IOException: HftpFileSystem([EMAIL PROTECTED]) and
> Key([EMAIL PROTECTED]://namenode-nn:4444) do not match.
> {noformat}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to