[
https://issues.apache.org/jira/browse/HADOOP-1915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12585866#action_12585866
]
Hadoop QA commented on HADOOP-1915:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12379451/hadoop-1915-v7.patch
against trunk revision 643282.
@author +1. The patch does not contain any @author tags.
tests included -1. The patch doesn't appear to include any new or modified
tests.
Please justify why no tests are needed for this patch.
javadoc +1. The javadoc tool did not generate any warning messages.
javac +1. The applied patch does not generate any new javac compiler
warnings.
release audit +1. The applied patch does not generate any new release
audit warnings.
findbugs -1. The patch appears to introduce 1 new Findbugs warnings.
core tests -1. The patch failed core unit tests.
contrib tests +1. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2171/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2171/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2171/artifact/trunk/build/test/checkstyle-errors.html
Console output:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2171/console
This message is automatically generated.
> adding counters methods using String (as opposed to Enum)
> ---------------------------------------------------------
>
> Key: HADOOP-1915
> URL: https://issues.apache.org/jira/browse/HADOOP-1915
> Project: Hadoop Core
> Issue Type: New Feature
> Environment: all
> Reporter: Alejandro Abdelnur
> Assignee: Tom White
> Priority: Minor
> Fix For: 0.17.0
>
> Attachments: hadoop-1915-v2.patch, hadoop-1915-v3.patch,
> hadoop-1915-v4.patch, hadoop-1915-v5.patch, hadoop-1915-v6.patch,
> hadoop-1915-v7.patch, hadoop-1915.patch
>
>
> Currently to use the counters from within Map/Reduce code Enums have to be
> used, the Enum class defines the group and the Enum itself the counter.
> Internally they are converted to Strings (the class name and the enum
> toString) and you can retrieve them as strings from the client API.
> Using dynamic counters (driven by configuration of the map/reduce) is not
> easy with the counters Enum based API. For example, currently I have an Enum
> class with 50 enums and we have to map the cardinality to the counter name on
> the client. This is cumbersome.
> This could be easily improve by adding a String based counter method
> increment(String group, String counter, long count) to allow use of the
> counters without Enums.
> Internally this method already exists, so the changes are minimal.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
