[ 
https://issues.apache.org/jira/browse/HADOOP-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12586323#action_12586323
 ] 

Amar Kamat commented on HADOOP-3101:
------------------------------------

Three comments
1) You can delete the {{throw IOException}} statement instead of commenting it 
out.
2) Because of spaces there is a diff generated (line 29 and 32 of the patch). I 
think we can avoid that. 
3) Plz document the change made in {{GenericOptionsParser.java}} in the 
javadoc. Btw {{getRemainingArgs()}} is a public api and there is a change is 
what it returns. Should there be a concern?
Rest looks good.

> 'bin/hadoop job' should display the help and silently exit
> ----------------------------------------------------------
>
>                 Key: HADOOP-3101
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3101
>             Project: Hadoop Core
>          Issue Type: Bug
>            Reporter: Amar Kamat
>            Assignee: Edward J. Yoon
>            Priority: Minor
>         Attachments: 3101.patch
>
>
> Currently 'bin/hadoop job' displays help and throws an exception. Like other 
> commands (e.g dfs) it should silently come out.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to