[ 
https://issues.apache.org/jira/browse/HADOOP-3204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12586959#action_12586959
 ] 

Chris Douglas commented on HADOOP-3204:
---------------------------------------

bq. All the operations done in LocalFSMerger throw IOException and hence 
LocalFSMerger expects IOException. I think a better approach would be to make 
FSError extend IOException or something like that. Fixing the code to catch 
FSerror when IOException is expected is incorrect.

I disagree. Per HADOOP-3154 and HADOOP-3166, it is critical that any worker 
threads whose death could result in data loss are handled by (or kill) the main 
thread, including (perhaps especially) Errors. Besides, FSError cannot extend 
both Error and IOException.

> LocalFSMerger needs to catch throwable
> --------------------------------------
>
>                 Key: HADOOP-3204
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3204
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>         Environment: Revision: 645751
>            Reporter: Koji Noguchi
>
> I haven't used trunk(0.17) so I don't know what would happen when FSError is 
> thrown within LocalFSMerger thread.
> Does it have the same problem as HADOOP-3154?  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to