[
https://issues.apache.org/jira/browse/HADOOP-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12587355#action_12587355
]
Raghu Angadi commented on HADOOP-1373:
--------------------------------------
The findbugs warning is for a line that is not changed in the patch : {code}
if (thisAuthority == thatAuthority || // & authorities match {code}
{noformat}
Bug type ES_COMPARING_STRINGS_WITH_EQ (click for details)
In class org.apache.hadoop.fs.FileSystem
In method org.apache.hadoop.fs.FileSystem.checkPath(Path)
Actual type java.lang.String
At FileSystem.java:[line 297]
Details
ES_COMPARING_STRINGS_WITH_EQ: Comparison of String objects using == or !=
{noformat}
The description says :
bq. This code compares java.lang.String objects for reference equality using
the == or != operators. Unless both strings are either constants in a source
file, or have been interned using the String.intern() method, the same string
value may be represented by two different String objects. Consider using the
equals(Object) method instead.
I tried casting them to 'Object' in the same line, but didn't work. AFICS this
usage is fine. Any one sees a real issue here?
> checkPath() throws IllegalArgumentException
> -------------------------------------------
>
> Key: HADOOP-1373
> URL: https://issues.apache.org/jira/browse/HADOOP-1373
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.12.3
> Environment: Windows, Linux
> Reporter: Konstantin Shvachko
> Assignee: Edward J. Yoon
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: 1373.patch, 1373_v02.patch, 1373_v03.patch,
> 1373_v04.patch, 1373_v04.patch
>
>
> This was introduced recently in one of the patches committed around 05/15 or
> 05/14.
> I am running TestDFSIO on a two node cluster. Here is the exception I get
> 07/05/15 19:14:53 INFO mapred.TaskInProgress: Error from
> task_0001_m_000007_0: java.lang.IllegalArgumentException: Wrong FS:
> hdfs://MY-HOST:7017/benchmarks/TestDFSIO/io_control/in_file_test_io_7,
> expected: hdfs://my-host:7017
> at org.apache.hadoop.fs.FileSystem.checkPath(FileSystem.java:230)
> at
> org.apache.hadoop.dfs.DistributedFileSystem$RawDistributedFileSystem.getPath(DistributedFileSystem.java:110)
> at
> org.apache.hadoop.dfs.DistributedFileSystem$RawDistributedFileSystem.exists(DistributedFileSystem.java:170)
> at org.apache.hadoop.fs.FilterFileSystem.exists(FilterFileSystem.java:168)
> at
> org.apache.hadoop.fs.ChecksumFileSystem.open(ChecksumFileSystem.java:335)
> at org.apache.hadoop.io.SequenceFile$Reader.<init>(SequenceFile.java:1162)
> at org.apache.hadoop.io.SequenceFile$Reader.<init>(SequenceFile.java:1156)
> at
> org.apache.hadoop.mapred.SequenceFileRecordReader.<init>(SequenceFileRecordReader.java:40)
> at
> org.apache.hadoop.mapred.SequenceFileInputFormat.getRecordReader(SequenceFileInputFormat.java:54)
> at org.apache.hadoop.mapred.MapTask.run(MapTask.java:149)
> at org.apache.hadoop.mapred.TaskTracker$Child.main(TaskTracker.java:1709)
> I confess, my config on one of the machines specifies name-node
> "MY-HOST:7017" and on the other one "my-host:7017".
> But that was acceptable before and should stay that way in the future afaiu.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
