[ 
https://issues.apache.org/jira/browse/HADOOP-3208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12587479#action_12587479
 ] 

Hadoop QA commented on HADOOP-3208:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12379711/writableDeserializer_v2.patch
against trunk revision 645773.

    @author +1.  The patch does not contain any @author tags.

    tests included +1.  The patch appears to include 6 new or modified tests.

    javadoc +1.  The javadoc tool did not generate any warning messages.

    javac +1.  The applied patch does not generate any new javac compiler 
warnings.

    release audit +1.  The applied patch does not generate any new release 
audit warnings.

    findbugs +1.  The patch does not introduce any new Findbugs warnings.

    core tests +1.  The patch passed core unit tests.

    contrib tests +1.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2194/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2194/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2194/artifact/trunk/build/test/checkstyle-errors.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2194/console

This message is automatically generated.

> WritableDeserializer does not pass the Configuration to deserialized Writables
> ------------------------------------------------------------------------------
>
>                 Key: HADOOP-3208
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3208
>             Project: Hadoop Core
>          Issue Type: Bug
>    Affects Versions: 0.17.0
>            Reporter: Enis Soztutar
>            Assignee: Enis Soztutar
>            Priority: Blocker
>             Fix For: 0.17.0
>
>         Attachments: writableDeserializer_v1.patch, 
> writableDeserializer_v2.patch
>
>
> {{WritableDeserializer}} does not hold a reference to the Configuration 
> object, so it does not pass it to deserialized writables, but uses 
> ReflectionUtils.newInstance(writableClass, null), which results in objects 
> defining Configurable interface to be initialized with null configuration. 
> Serialization framework have been introduced in 0.17, so this bug affects 
> 0.17. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to