[ 
https://issues.apache.org/jira/browse/HADOOP-3272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12590648#action_12590648
 ] 

lohit vijayarenu commented on HADOOP-3272:
------------------------------------------

Thanks Koji. Pasting one more jmap dump

Before patch
{noformat}
[lohit@ ~]$jmap -histo:live 2265 | grep Block
 11:      9343      298976  org.apache.hadoop.dfs.BlocksMap$BlockInfo
 17:      9342      224208  org.apache.hadoop.dfs.Block
 27:      1130       50512  [Lorg.apache.hadoop.dfs.BlocksMap$BlockInfo;
551:         4          64  
org.apache.hadoop.dfs.BlockCrcUpgradeObjectNamenode$UpgradeStatus
595:         2          48  
org.apache.hadoop.dfs.PendingReplicationBlocks$PendingBlockInfo
599:         1          48  org.apache.hadoop.dfs.PendingReplicationBlocks
752:         1          32  
[Lorg.apache.hadoop.dfs.BlockCrcUpgradeObjectNamenode$UpgradeStatus;
930:         1          16  
org.apache.hadoop.dfs.PendingReplicationBlocks$PendingReplicationMonitor
974:         1          16  org.apache.hadoop.dfs.BlocksMap
989:         1          16  org.apache.hadoop.dfs.UnderReplicatedBlocks
1003:         1           8  org.apache.hadoop.dfs.Block$1
1025:         1           8  org.apache.hadoop.dfs.LocatedBlocks$2
1083:         1           8  org.apache.hadoop.dfs.LocatedBlock$1
1105:         1           8  org.apache.hadoop.dfs.BlockCommand$1
{noformat}

After patch
{noformat}
[lohit@ ~]$jmap -histo:live 19406 | grep Block 
 11:      9224      295168  org.apache.hadoop.dfs.BlocksMap$BlockInfo
 22:       992       47552  [Lorg.apache.hadoop.dfs.BlocksMap$BlockInfo;
505:         4          64  
org.apache.hadoop.dfs.BlockCrcUpgradeObjectNamenode$UpgradeStatus
555:         1          48  org.apache.hadoop.dfs.PendingReplicationBlocks
594:         1          40  java.util.concurrent.LinkedBlockingQueue
691:         1          32  
[Lorg.apache.hadoop.dfs.BlockCrcUpgradeObjectNamenode$UpgradeStatus;
821:         1          16  org.apache.hadoop.dfs.BlocksMap
828:         1          16  java.util.concurrent.LinkedBlockingQueue$Node
832:         1          16  org.apache.hadoop.dfs.UnderReplicatedBlocks
854:         1          16  
org.apache.hadoop.dfs.PendingReplicationBlocks$PendingReplicationMonitor
918:         1           8  org.apache.hadoop.dfs.BlockCommand$1
997:         1           8  org.apache.hadoop.dfs.LocatedBlock$1
1005:         1           8  org.apache.hadoop.dfs.Block$1
1006:         1           8  org.apache.hadoop.dfs.LocatedBlocks$2
{noformat}

> Reduce redundant copy of Block object in BlocksMap.map hash map
> ---------------------------------------------------------------
>
>                 Key: HADOOP-3272
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3272
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>         Environment: All
>            Reporter: lohit vijayarenu
>            Assignee: lohit vijayarenu
>             Fix For: 0.18.0
>
>         Attachments: HADOOP-3272.patch
>
>
> Looks like we might have redundant copy of Block object as Key for 
> BlocksMap.map hash map. We should restore this to using same object for both 
> Key, Value to save space. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to