[
https://issues.apache.org/jira/browse/HADOOP-3270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12590821#action_12590821
]
Hadoop QA commented on HADOOP-3270:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12380583/3270_20080420.patch
against trunk revision 645773.
@author +1. The patch does not contain any @author tags.
tests included +1. The patch appears to include 3 new or modified tests.
javadoc +1. The javadoc tool did not generate any warning messages.
javac +1. The applied patch does not generate any new javac compiler
warnings.
release audit +1. The applied patch does not generate any new release
audit warnings.
findbugs +1. The patch does not introduce any new Findbugs warnings.
core tests +1. The patch passed core unit tests.
contrib tests +1. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2287/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2287/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2287/artifact/trunk/build/test/checkstyle-errors.html
Console output:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2287/console
This message is automatically generated.
> Constant DatanodeCommand should be stored in static fianl immutable variables.
> ------------------------------------------------------------------------------
>
> Key: HADOOP-3270
> URL: https://issues.apache.org/jira/browse/HADOOP-3270
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Minor
> Attachments: 3270_20080417.patch, 3270_20080418.patch,
> 3270_20080420.patch
>
>
> DatanodeCommand like DNA_REGISTER, DNA_BLOCKREPORT and DNA_FINALIZE are
> constant command. New objects should not be created for each time when using
> these commands.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
