[ 
https://issues.apache.org/jira/browse/HADOOP-3295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12591624#action_12591624
 ] 

Runping Qi commented on HADOOP-3295:
------------------------------------


Note that you have made public api changes:
{code}
public LineRecordWriter(DataOutputStream out)
{code}
into 
{code}
public LineRecordWriter(DataOutputStream out, String keyValueSeparator) {
{code}
It is a better to the keep the original one as an overloaded constructor:
{code}
public LineRecordWriter(DataOutputStream out) {
    LineRecordWriter(out, "\t");
}
{code}



> Allow TextOutputFormat to use configurable separators
> -----------------------------------------------------
>
>                 Key: HADOOP-3295
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3295
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: io
>            Reporter: Zheng Shao
>            Assignee: Zheng Shao
>            Priority: Minor
>         Attachments: 3295.patch
>
>
> TextOutputFormat use hardcoded tab as key-value separator. We should allow 
> configurable separators like ^A, etc.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to