[ 
https://issues.apache.org/jira/browse/HADOOP-3246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12591949#action_12591949
 ] 

Ankur commented on HADOOP-3246:
-------------------------------

So I tested the patch locally after adding the JARS to the test env manually 
and disabling the modification check in script 'test-patch.sh'.
Here's the report on my machine

-1 overall.
     [exec]
     [exec]     @author +1.  The patch does not contain any @author tags.
     [exec]
     [exec]     tests included +1.  The patch appears to include 9 new or 
modified tests.
     [exec]
     [exec]     javadoc +1.  The javadoc tool did not generate any warning 
messages.
     [exec]
     [exec]     javac +1.  The applied patch does not generate any new javac 
compiler warnings.
     [exec]
     [exec]     findbugs -1.  The patch appears to introduce 1 new Findbugs 
warnings.

The find bugs warning is due to  a couple of System.exit()  in the code which 
even though is bad practice but still acceptable in my opinion for a shell 
application like this. Still I can go ahead and change this once I get some 
review comments.

> FTP client over HDFS
> --------------------
>
>                 Key: HADOOP-3246
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3246
>             Project: Hadoop Core
>          Issue Type: New Feature
>          Components: util
>    Affects Versions: 0.16.3
>            Reporter: Ankur
>            Priority: Minor
>         Attachments: ftpClient.patch
>
>
> An FTP client that stores content directly into HDFS allows data from FTP 
> serves to be stored directly into HDFS instead of first copying the data 
> locally and then uploading it into HDFS. The benefits are apparent from an 
> administrative perspective as large datasets can be pulled from FTP servers 
> with minimal human intervention.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to