[
https://issues.apache.org/jira/browse/HADOOP-2188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12593402#action_12593402
]
Hadoop QA commented on HADOOP-2188:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12381200/ipc-timeout8.patch
against trunk revision 645773.
@author +1. The patch does not contain any @author tags.
tests included +1. The patch appears to include 9 new or modified tests.
javadoc +1. The javadoc tool did not generate any warning messages.
javac +1. The applied patch does not generate any new javac compiler
warnings.
release audit +1. The applied patch does not generate any new release
audit warnings.
findbugs +1. The patch does not introduce any new Findbugs warnings.
core tests +1. The patch passed core unit tests.
contrib tests +1. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2352/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2352/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2352/artifact/trunk/build/test/checkstyle-errors.html
Console output:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2352/console
This message is automatically generated.
> RPC should send a ping rather than use client timeouts
> ------------------------------------------------------
>
> Key: HADOOP-2188
> URL: https://issues.apache.org/jira/browse/HADOOP-2188
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs, ipc
> Affects Versions: 0.16.1
> Reporter: Owen O'Malley
> Assignee: Hairong Kuang
> Fix For: 0.18.0
>
> Attachments: ipc-timeout.patch, ipc-timeout1.patch,
> ipc-timeout2.patch, ipc-timeout3.patch, ipc-timeout4.patch,
> ipc-timeout5.patch, ipc-timeout6.patch, ipc-timeout7.patch,
> ipc-timeout8.patch, rpc-to.patch
>
>
> Current RPC (really IPC) relies on client side timeouts to find "dead"
> sockets. I propose that we have a thread that once a minute (if the
> connection has been idle) writes a "ping" message to the socket. The client
> can detect a dead socket by the resulting error on the write, so no client
> side timeout is required. Also note that the ipc server does not need to
> respond to the ping, just discard it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
