[
https://issues.apache.org/jira/browse/HADOOP-3281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12593664#action_12593664
]
Hadoop QA commented on HADOOP-3281:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12381244/3281.patch
against trunk revision 645773.
@author +1. The patch does not contain any @author tags.
tests included -1. The patch doesn't appear to include any new or modified
tests.
Please justify why no tests are needed for this patch.
javadoc +1. The javadoc tool did not generate any warning messages.
javac +1. The applied patch does not generate any new javac compiler
warnings.
release audit +1. The applied patch does not generate any new release
audit warnings.
findbugs +1. The patch does not introduce any new Findbugs warnings.
core tests +1. The patch passed core unit tests.
contrib tests +1. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2359/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2359/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2359/artifact/trunk/build/test/checkstyle-errors.html
Console output:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2359/console
This message is automatically generated.
> bin/hadoop script should check class name before running java
> -------------------------------------------------------------
>
> Key: HADOOP-3281
> URL: https://issues.apache.org/jira/browse/HADOOP-3281
> Project: Hadoop Core
> Issue Type: Bug
> Components: scripts
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Edward J. Yoon
> Fix For: 0.18.0
>
> Attachments: 3281.patch
>
>
> When the first parameter ($1) cannot be matched with one of existing hadoop
> commnads, the parameter will be considered as a class name and the script
> will pass it to java. For examples,
> {noformat}
> bash-3.2$ ./bin/hadoop -version
> java version "1.5.0_14"
> Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_14-b03)
> Java HotSpot(TM) Client VM (build 1.5.0_14-b03, mixed mode)
> bash-3.2$ ./bin/hadoop -help
> Usage: java [-options] class [args...]
> (to execute a class)
> or java [-options] -jar jarfile [args...]
> (to execute a jar file)
> ...
> {noformat}
> The behavior above is confusing. We should check whether the parameter is a
> valid class name before passing it to java.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
