[ 
https://issues.apache.org/jira/browse/HADOOP-3315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596159#action_12596159
 ] 

Owen O'Malley commented on HADOOP-3315:
---------------------------------------

* getClosest should specify that it means closest after the given key
* row ids should be longs
* does the compression of the key index follow tfile.compressionCodec?
* should the ioffset and moffset (or my key, row, and meta offsets) be vints?
* I think the append method that takes an input stream should be:
{code}
void appendRaw(int keyLength, InputStream key, int valueLength, InputStream 
value) throws IOException;
{code}
* Most of the methods should have "throws IOException"
* It is useful to be able to get the key/value class names without the class. 
I'd replace the getKeyClass and getValueClass with string equivalents:
{code}
String getKeyClassName();
String getValueClassName();
{code}
* I assume that seekToKey returns false, if the key does not exist, but the 
file pointer may have moved.

> New binary file format
> ----------------------
>
>                 Key: HADOOP-3315
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3315
>             Project: Hadoop Core
>          Issue Type: New Feature
>          Components: io
>            Reporter: Owen O'Malley
>            Assignee: Srikanth Kakani
>         Attachments: Tfile-1.pdf
>
>
> SequenceFile's block compression format is too complex and requires 4 codecs 
> to compress or decompress. It would be good to have a file format that only 
> needs 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to