[ 
https://issues.apache.org/jira/browse/HADOOP-3193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596947#action_12596947
 ] 

lohit vijayarenu commented on HADOOP-3193:
------------------------------------------

+1 patch looks good. One small thing, the metric seem to report number of 
corrupt blocks reported over time. Should it be changed to number of corrupt 
blocks in the system at any point of time, possibly using MetricsIntValue. And 
also, namesystem.markBlockAsCorrupt  logs a message about  this inside 
corruptReplicas.addToCorruptReplicasMap function. 

> Discovery of corrupt block reported in name node log
> ----------------------------------------------------
>
>                 Key: HADOOP-3193
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3193
>             Project: Hadoop Core
>          Issue Type: New Feature
>          Components: dfs
>            Reporter: Robert Chansler
>         Attachments: 3193-0.patch
>
>
> Any discovery of a corrupt/unreadable block must be reported in the name node 
> log.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to