[
https://issues.apache.org/jira/browse/HADOOP-3398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12597329#action_12597329
]
Hadoop QA commented on HADOOP-3398:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12382146/3398-1.patch
against trunk revision 656852.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2482/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2482/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2482/artifact/trunk/build/test/checkstyle-errors.html
Console output:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2482/console
This message is automatically generated.
> ReduceTask::closestPowerOf2 is inefficient
> ------------------------------------------
>
> Key: HADOOP-3398
> URL: https://issues.apache.org/jira/browse/HADOOP-3398
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Reporter: Chris Douglas
> Assignee: Chris Douglas
> Priority: Trivial
> Fix For: 0.18.0
>
> Attachments: 3398-0.patch, 3398-1.patch
>
>
> ReduceTask computes the "closest power of 2" using loops
> {code}
> private static int getClosestPowerOf2(int value) {
> int power = 0;
> int approx = 1;
> while (approx < value) {
> ++power;
> approx = (approx << 1);
> }
> if ((value - (approx >> 1)) < (approx - value)) {
> --power;
> }
> return power;
> }
> {code}
> This could be improved.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
