[ 
https://issues.apache.org/jira/browse/HADOOP-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12599101#action_12599101
 ] 

Tsz Wo (Nicholas), SZE commented on HADOOP-3310:
------------------------------------------------

> 2. internalReleaseLease invokes lease.renew(). Instead, 
> LeaseManager.removeExpiredLease() should invoke lease.renew(). The reason 
> being that a lease actually corresponds to multiple files.
>
> 3. removeExpiredLease is also invoked from startFileInternal. In this case, 
> only one file in the lease should be recovered. The current code recovers all 
> the files in the lease.

Then, removeExpiredLease is not useful anymore since the uses of it are 
different in startFileInternal and LeaseManager.Monitor.run().  I will remove 
it and fix the caller's codes individually.

> Lease recovery for append
> -------------------------
>
>                 Key: HADOOP-3310
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3310
>             Project: Hadoop Core
>          Issue Type: New Feature
>          Components: dfs
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: 3310_20080514.patch, 3310_20080516b.patch, 
> 3310_20080516c.patch, 3310_20080519.patch, 3310_20080519b.patch, 
> 3310_20080520.patch, 3310_20080521.patch
>
>
> In order to support file append, a GenerationStamp is associated with each 
> block.  Lease recovery will be performed when there is a possibility that the 
> replicas of a block in a lease may have different GenerationStamp values.
> For more details, see the documentation in HADOOP-1700.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to